mbox

[U-Boot,i2c] Pull request

Message ID 524A6E40.9010004@denx.de
State Changes Requested
Delegated to: Tom Rini
Headers show

Pull-request

git://git.denx.de/u-boot-i2c.git master

Message

Heiko Schocher Oct. 1, 2013, 6:40 a.m. UTC 
Hello Tom,

please pull from u-boot-i2c.git

The following changes since commit 6b40852da5c8dd710f9d61204affff3c6a3c9d22:

   Sound: MAX98095: Support I2S0 channel (2013-09-24 09:10:33 -0400)

are available in the git repository at:

   git://git.denx.de/u-boot-i2c.git master

for you to fetch changes up to e436193269620579164d7db4296a3d7a378dbf8d:

   exynos: i2c: Fix i2c driver to handle NACKs properly (2013-10-01 08:33:16 +0200)

----------------------------------------------------------------
Naveen Krishna Ch (1):
       exynos: i2c: Fix i2c driver to handle NACKs properly

  drivers/i2c/s3c24x0_i2c.c | 213 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------
  1 file changed, 89 insertions(+), 124 deletions(-)

bye,
Heiko

Comments

Tom Rini Oct. 2, 2013, 1:04 p.m. UTC | #1 
On Tue, Oct 01, 2013 at 08:40:00AM +0200, Heiko Schocher wrote:

> Hello Tom,
> 
> please pull from u-boot-i2c.git
> 
> The following changes since commit 6b40852da5c8dd710f9d61204affff3c6a3c9d22:
> 
>   Sound: MAX98095: Support I2S0 channel (2013-09-24 09:10:33 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-i2c.git master
> 
> for you to fetch changes up to e436193269620579164d7db4296a3d7a378dbf8d:
> 
>   exynos: i2c: Fix i2c driver to handle NACKs properly (2013-10-01 08:33:16 +0200)
> 
> ----------------------------------------------------------------
> Naveen Krishna Ch (1):
>       exynos: i2c: Fix i2c driver to handle NACKs properly
> 
>  drivers/i2c/s3c24x0_i2c.c | 213 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------
>  1 file changed, 89 insertions(+), 124 deletions(-)

NAK:

Testing VCMA9 on -00058-ga882b9e
Wed Oct  2 09:02:24 EDT 2013
Configuring for VCMA9 board...
s3c24x0_i2c.c:234:3: error: 'i' undeclared (first use in this
function)
make[1]: *** [/home/trini/work/u-boot/u-boot/VCMA9/drivers/i2c/s3c24x0_i2c.o] Error 1
make: *** [/home/trini/work/u-boot/u-boot/VCMA9/drivers/i2c/libi2c.o] Error 2
/opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-size: 'VCMA9/u-boot': No such file
s3c24x0_i2c.c: In function 'i2c_init':
s3c24x0_i2c.c:234:3: error: 'i' undeclared (first use in this function)
s3c24x0_i2c.c:234:3: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [/home/trini/work/u-boot/u-boot/VCMA9/drivers/i2c/s3c24x0_i2c.o] Error 1
make: *** [/home/trini/work/u-boot/u-boot/VCMA9/drivers/i2c/libi2c.o] Error 2
make: *** Waiting for unfinished jobs....

--------------------- SUMMARY ----------------------------
Boards compiled: 1
Boards with errors: 1 ( VCMA9 )
----------------------------------------------------------
Command exited with non-zero status 1
Heiko Schocher Oct. 2, 2013, 1:47 p.m. UTC | #2 
Hello Tom,

Am 02.10.2013 15:04, schrieb Tom Rini:
> On Tue, Oct 01, 2013 at 08:40:00AM +0200, Heiko Schocher wrote:
>
>> Hello Tom,
>>
>> please pull from u-boot-i2c.git
>>
>> The following changes since commit 6b40852da5c8dd710f9d61204affff3c6a3c9d22:
>>
>>    Sound: MAX98095: Support I2S0 channel (2013-09-24 09:10:33 -0400)
>>
>> are available in the git repository at:
>>
>>    git://git.denx.de/u-boot-i2c.git master
>>
>> for you to fetch changes up to e436193269620579164d7db4296a3d7a378dbf8d:
>>
>>    exynos: i2c: Fix i2c driver to handle NACKs properly (2013-10-01 08:33:16 +0200)
>>
>> ----------------------------------------------------------------
>> Naveen Krishna Ch (1):
>>        exynos: i2c: Fix i2c driver to handle NACKs properly
>>
>>   drivers/i2c/s3c24x0_i2c.c | 213 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------
>>   1 file changed, 89 insertions(+), 124 deletions(-)
>
> NAK:
>
> Testing VCMA9 on -00058-ga882b9e
> Wed Oct  2 09:02:24 EDT 2013
> Configuring for VCMA9 board...
> s3c24x0_i2c.c:234:3: error: 'i' undeclared (first use in this

Ups, Thanks for detecting this ...

bye,
Heiko