| Message ID | 1380576500-8531-1-git-send-email-peter@korsgaard.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Peter Korsgaard <peter@korsgaard.com> Date: Mon, 30 Sep 2013 23:28:20 +0200 > Pass-all-multicast is controlled by bit 3 in RX control, not bit 2 > (pass undersized frames). > > Reported-by: Joseph Chang <joseph_chang@davicom.com.tw> > Signed-off-by: Peter Korsgaard <peter@korsgaard.com> Applied, thanks. It would be so much better if these register values were all properly documented, one by one, with macros. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "David" == David Miller <davem@davemloft.net> writes:
Hi,
David> Applied, thanks.
Thanks!
David> It would be so much better if these register values were all
David> properly documented, one by one, with macros.
Yes, I know. I'll take a look at getting rid of all the magic values.
diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c index 2dbb946..c6867f9 100644 --- a/drivers/net/usb/dm9601.c +++ b/drivers/net/usb/dm9601.c @@ -303,7 +303,7 @@ static void dm9601_set_multicast(struct net_device *net) rx_ctl |= 0x02; } else if (net->flags & IFF_ALLMULTI || netdev_mc_count(net) > DM_MAX_MCAST) { - rx_ctl |= 0x04; + rx_ctl |= 0x08; } else if (!netdev_mc_empty(net)) { struct netdev_hw_addr *ha;
Pass-all-multicast is controlled by bit 3 in RX control, not bit 2 (pass undersized frames). Reported-by: Joseph Chang <joseph_chang@davicom.com.tw> Signed-off-by: Peter Korsgaard <peter@korsgaard.com> --- drivers/net/usb/dm9601.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)