Patchwork ARM: imx: Include linux/err.h

login
register
mail settings
Submitter Thierry Reding
Date Sept. 30, 2013, 12:04 p.m.
Message ID <1380542691-24756-1-git-send-email-treding@nvidia.com>
Download mbox | patch
Permalink /patch/279141/
State New
Headers show

Comments

Thierry Reding - Sept. 30, 2013, 12:04 p.m.
The IS_ERR() macro is defined in the linux/err.h header file, so include
it explicitly.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 arch/arm/mach-imx/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Shawn Guo - Oct. 5, 2013, 2:24 a.m.
On Mon, Sep 30, 2013 at 02:04:51PM +0200, Thierry Reding wrote:
> The IS_ERR() macro is defined in the linux/err.h header file, so include
> it explicitly.

Hmm, I can not find IS_ERR() in arch/arm/mach-imx/cpu.c

Shawn

> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  arch/arm/mach-imx/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/cpu.c b/arch/arm/mach-imx/cpu.c
> index fae2c9a..ba3b498 100644
> --- a/arch/arm/mach-imx/cpu.c
> +++ b/arch/arm/mach-imx/cpu.c
> @@ -1,4 +1,4 @@
> -
> +#include <linux/err.h>
>  #include <linux/module.h>
>  #include <linux/io.h>
>  #include <linux/of.h>
> -- 
> 1.8.4
>
Shawn Guo - Oct. 5, 2013, 2:28 a.m.
On Sat, Oct 05, 2013 at 10:24:23AM +0800, Shawn Guo wrote:
> On Mon, Sep 30, 2013 at 02:04:51PM +0200, Thierry Reding wrote:
> > The IS_ERR() macro is defined in the linux/err.h header file, so include
> > it explicitly.
> 
> Hmm, I can not find IS_ERR() in arch/arm/mach-imx/cpu.c

Sorry, I did not look at the correct tree.

Applied, thanks.

Shawn

Patch

diff --git a/arch/arm/mach-imx/cpu.c b/arch/arm/mach-imx/cpu.c
index fae2c9a..ba3b498 100644
--- a/arch/arm/mach-imx/cpu.c
+++ b/arch/arm/mach-imx/cpu.c
@@ -1,4 +1,4 @@ 
-
+#include <linux/err.h>
 #include <linux/module.h>
 #include <linux/io.h>
 #include <linux/of.h>