Patchwork [base,08/13] zlib: fixup sdk build with "USE_sdk_static" set

login
register
mail settings
Submitter Jacob Kjaergaard
Date Sept. 30, 2013, 8:23 a.m.
Message ID <4e2a300dccbaa6519c4a6305a69ed245a3d0f67a.1380529272.git.jacob.kjaergaard@prevas.dk>
Download mbox | patch
Permalink /patch/278950/
State Rejected
Delegated to: Esben Haabendal
Headers show

Comments

Jacob Kjaergaard - Sept. 30, 2013, 8:23 a.m.
From: Jacob Kjaergaard <jacob.kjaergaard@prevas.dk>

zlib does not build on x86-64 with this use flag set. we override it
at recipe level.
---
 recipes/zlib/zlib.inc |    3 +++
 1 file changed, 3 insertions(+)
Esben Haabendal - Oct. 14, 2013, 12:56 p.m.
<jabk@prevas.dk> writes:

> From: Jacob Kjaergaard <jacob.kjaergaard@prevas.dk>
>
> zlib does not build on x86-64 with this use flag set. we override it
> at recipe level.

I don't think that is a good idea.

If you set the USE_sdk_static flag, you have specified that you want to
build a static SDK image, so falling back to building a non-static SDK
is not a desired action.

If a specific SDK architecture does not support building something
statically, the "something" should either be fixed, excluded from the
build, or the USE_sdk_static flag should be unset.

/Esben

> ---
>  recipes/zlib/zlib.inc |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/recipes/zlib/zlib.inc b/recipes/zlib/zlib.inc
> index 7fdd823..4857446 100644
> --- a/recipes/zlib/zlib.inc
> +++ b/recipes/zlib/zlib.inc
> @@ -21,6 +21,9 @@ do_configure() {
>  	fi
>  }
>  
> +#zlib does not compile for sdk using the "sdk-static" feature so we disable it
> +RECIPE_USE_sdk_static = "0"
> +
>  EXTRA_OEMAKE:HOST_LIBC_mingw = "PREFIX=${HOST_PREFIX}"
>  
>  EXTRA_OEMAKE_INSTALL:HOST_LIBC_mingw = "BINARY_PATH=${sharedlibdir} INCLUDE_PATH=${includedir} LIBRARY_PATH=${libdir} SHARED_MODE=1"
Esben Haabendal - Oct. 14, 2013, 12:56 p.m.
<jabk@prevas.dk> writes:

> From: Jacob Kjaergaard <jacob.kjaergaard@prevas.dk>
>
> zlib does not build on x86-64 with this use flag set. we override it
> at recipe level.

I don't think that is a good idea.

If you set the USE_sdk_static flag, you have specified that you want to
build a static SDK image, so falling back to building a non-static SDK
is not a desired action.

If a specific SDK architecture does not support building something
statically, the "something" should either be fixed, excluded from the
build, or the USE_sdk_static flag should be unset.

/Esben

> ---
>  recipes/zlib/zlib.inc |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/recipes/zlib/zlib.inc b/recipes/zlib/zlib.inc
> index 7fdd823..4857446 100644
> --- a/recipes/zlib/zlib.inc
> +++ b/recipes/zlib/zlib.inc
> @@ -21,6 +21,9 @@ do_configure() {
>  	fi
>  }
>  
> +#zlib does not compile for sdk using the "sdk-static" feature so we disable it
> +RECIPE_USE_sdk_static = "0"
> +
>  EXTRA_OEMAKE:HOST_LIBC_mingw = "PREFIX=${HOST_PREFIX}"
>  
>  EXTRA_OEMAKE_INSTALL:HOST_LIBC_mingw = "BINARY_PATH=${sharedlibdir} INCLUDE_PATH=${includedir} LIBRARY_PATH=${libdir} SHARED_MODE=1"

Patch

diff --git a/recipes/zlib/zlib.inc b/recipes/zlib/zlib.inc
index 7fdd823..4857446 100644
--- a/recipes/zlib/zlib.inc
+++ b/recipes/zlib/zlib.inc
@@ -21,6 +21,9 @@  do_configure() {
 	fi
 }
 
+#zlib does not compile for sdk using the "sdk-static" feature so we disable it
+RECIPE_USE_sdk_static = "0"
+
 EXTRA_OEMAKE:HOST_LIBC_mingw = "PREFIX=${HOST_PREFIX}"
 
 EXTRA_OEMAKE_INSTALL:HOST_LIBC_mingw = "BINARY_PATH=${sharedlibdir} INCLUDE_PATH=${includedir} LIBRARY_PATH=${libdir} SHARED_MODE=1"