Patchwork cris/PCI: Remove pci_mem_start

login
register
mail settings
Submitter Myron Stowe
Date Sept. 28, 2013, 5:55 p.m.
Message ID <20130928175548.8612.84198.stgit@amt.stowe>
Download mbox | patch
Permalink /patch/278754/
State Accepted
Headers show

Comments

Myron Stowe - Sept. 28, 2013, 5:55 p.m.
Remove unused 'pci_mem_start' variable.

CC: Mikael Starvik <starvik@axis.com>
CC: Jesper Nilsson <jesper.nilsson@axis.com>
Signed-off-by: Myron Stowe <myron.stowe@redhat.com>
---

 arch/cris/include/asm/pci.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bjorn Helgaas - Oct. 4, 2013, 8:21 p.m.
On Sat, Sep 28, 2013 at 11:55 AM, Myron Stowe <myron.stowe@redhat.com> wrote:
> Remove unused 'pci_mem_start' variable.
>
> CC: Mikael Starvik <starvik@axis.com>
> CC: Jesper Nilsson <jesper.nilsson@axis.com>
> Signed-off-by: Myron Stowe <myron.stowe@redhat.com>

Applied to pci/misc, thanks!

It'd be nice if we could someday get rid of PCIBIOS_MIN_IO and
PCIBIOS_MIN_MEM, too.  They're really just relics from the days when
we assumed there was a single host bridge, and we didn't have any idea
what the host bridge apertures were (or we assumed the host bridge
essentially subtractively decoded everything).

Now that we can tell the PCI core about host bridge apertures, the
arch should be able to achieve the effect of PCIBIOS_MIN_MEM by
clipping the window itself.

Bjorn

> ---
>
>  arch/cris/include/asm/pci.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/cris/include/asm/pci.h b/arch/cris/include/asm/pci.h
> index 146da90..f666734 100644
> --- a/arch/cris/include/asm/pci.h
> +++ b/arch/cris/include/asm/pci.h
> @@ -11,7 +11,6 @@
>
>  #define pcibios_assign_all_busses(void) 1
>
> -extern unsigned long pci_mem_start;
>  #define PCIBIOS_MIN_IO         0x1000
>  #define PCIBIOS_MIN_MEM                0x10000000
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/cris/include/asm/pci.h b/arch/cris/include/asm/pci.h
index 146da90..f666734 100644
--- a/arch/cris/include/asm/pci.h
+++ b/arch/cris/include/asm/pci.h
@@ -11,7 +11,6 @@ 
 
 #define pcibios_assign_all_busses(void) 1
 
-extern unsigned long pci_mem_start;
 #define PCIBIOS_MIN_IO		0x1000
 #define PCIBIOS_MIN_MEM		0x10000000