Patchwork [U-Boot] buildman: Use env to pick the python from $PATH

login
register
mail settings
Submitter Jagannadha Sutradharudu Teki
Date Sept. 28, 2013, 5:38 p.m.
Message ID <ea6aa303-cd7e-4629-ae34-7ae5e9c16d33@VA3EHSMHS044.ehs.local>
Download mbox | patch
Permalink /patch/278753/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Jagannadha Sutradharudu Teki - Sept. 28, 2013, 5:38 p.m.
python used in buildman doesn't need to be placed in
/usr/bin/python, So use env to ensure that the interpreter
will pick the python from environment.

Usefull with several versions of python's installed on system.

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
---
 tools/buildman/buildman.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Simon Glass - Sept. 30, 2013, 4:32 a.m.
On Sat, Sep 28, 2013 at 11:38 AM, Jagannadha Sutradharudu Teki
<jagannadha.sutradharudu-teki@xilinx.com> wrote:
> python used in buildman doesn't need to be placed in
> /usr/bin/python, So use env to ensure that the interpreter
> will pick the python from environment.
>
> Usefull with several versions of python's installed on system.
>
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>

Acked-by: Simon Glass <sjg@chromium.org>
Jagannadha Sutradharudu Teki - Oct. 15, 2013, 10:41 a.m.
Hi Tom,

On Mon, Sep 30, 2013 at 10:02 AM, Simon Glass <sjg@chromium.org> wrote:
> On Sat, Sep 28, 2013 at 11:38 AM, Jagannadha Sutradharudu Teki
> <jagannadha.sutradharudu-teki@xilinx.com> wrote:
>> python used in buildman doesn't need to be placed in
>> /usr/bin/python, So use env to ensure that the interpreter
>> will pick the python from environment.
>>
>> Usefull with several versions of python's installed on system.
>>
>> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
>
> Acked-by: Simon Glass <sjg@chromium.org>
> _______________________________________________

Can you pick this.
Tom Rini - Oct. 15, 2013, 12:45 p.m.
On Sat, Sep 28, 2013 at 11:08:14PM +0530, Jagannadha Sutradharudu Teki wrote:

> python used in buildman doesn't need to be placed in
> /usr/bin/python, So use env to ensure that the interpreter
> will pick the python from environment.
> 
> Usefull with several versions of python's installed on system.
> 
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

Patch

diff --git a/tools/buildman/buildman.py b/tools/buildman/buildman.py
index 6fba2f2..1a5c52d 100755
--- a/tools/buildman/buildman.py
+++ b/tools/buildman/buildman.py
@@ -1,4 +1,4 @@ 
-#!/usr/bin/python
+#!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium OS Authors.
 #