Patchwork [U-Boot,1/7] mtd: Fix function description in part_validate comment

login
register
mail settings
Submitter Otavio Salvador
Date Sept. 28, 2013, 3:24 a.m.
Message ID <1380338659-7896-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/278707/
State Superseded
Headers show

Comments

Otavio Salvador - Sept. 28, 2013, 3:24 a.m.
The part_validate comment had a wrong description of the actions it
does and referenced to non-existent functions while in fact it calls
'part_validate_eraseblock()'.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 common/cmd_mtdparts.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Eric Benard - Sept. 28, 2013, 1:06 p.m.
Hi Otavio,

Le Sat, 28 Sep 2013 00:24:12 -0300,
Otavio Salvador <otavio@ossystems.com.br> a écrit :

> The part_validate comment had a wrong description of the actions it
> does and referenced to non-existent functions while in fact it calls
> 'part_validate_eraseblock()'.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  common/cmd_mtdparts.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/common/cmd_mtdparts.c b/common/cmd_mtdparts.c
> index 3023479..0104285 100644
> --- a/common/cmd_mtdparts.c
> +++ b/common/cmd_mtdparts.c
> @@ -381,10 +381,10 @@ static int part_validate_eraseblock(struct mtdids *id, struct part_info *part)
>  
>  
>  /**
> - * Performs sanity check for supplied partition. Offset and size are verified
> - * to be within valid range. Partition type is checked and either
> - * parts_validate_nor() or parts_validate_nand() is called with the argument
> - * of part.
> + * Performs sanity check for supplied partition. Offset and size are
> + * verified to be within valid range. Partition type is checked and
> + * either part_validate_eraseblock() is called with the argument of

and now you can remove either ;-)

Eric

Patch

diff --git a/common/cmd_mtdparts.c b/common/cmd_mtdparts.c
index 3023479..0104285 100644
--- a/common/cmd_mtdparts.c
+++ b/common/cmd_mtdparts.c
@@ -381,10 +381,10 @@  static int part_validate_eraseblock(struct mtdids *id, struct part_info *part)
 
 
 /**
- * Performs sanity check for supplied partition. Offset and size are verified
- * to be within valid range. Partition type is checked and either
- * parts_validate_nor() or parts_validate_nand() is called with the argument
- * of part.
+ * Performs sanity check for supplied partition. Offset and size are
+ * verified to be within valid range. Partition type is checked and
+ * either part_validate_eraseblock() is called with the argument of
+ * part.
  *
  * @param id of the parent device
  * @param part partition to validate