Patchwork [v3,01/11] udev: explicitly include pthreads

login
register
mail settings
Submitter Spenser Gilliland
Date Sept. 26, 2013, 11:21 p.m.
Message ID <1380237714-2470-2-git-send-email-spenser@gillilanding.com>
Download mbox | patch
Permalink /patch/278298/
State Rejected
Headers show

Comments

Spenser Gilliland - Sept. 26, 2013, 11:21 p.m.
This fixes builds with Linaro hard float toolchains.

Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
---
 package/udev/udev.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Peter Korsgaard - Oct. 3, 2013, 8:41 p.m.
>>>>> "Spenser" == Spenser Gilliland <spenser@gillilanding.com> writes:

 Spenser> This fixes builds with Linaro hard float toolchains.

Sorry, what toolchain exactly? I just did a test build with our default
(Linaro 2013.08) ext toolchain, and didn't have any linker issues.


 Spenser> Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
 Spenser> ---
 Spenser>  package/udev/udev.mk |    2 +-
 Spenser>  1 files changed, 1 insertions(+), 1 deletions(-)

 Spenser> diff --git a/package/udev/udev.mk b/package/udev/udev.mk
 Spenser> index db86850..b512ec5 100644
 Spenser> --- a/package/udev/udev.mk
 Spenser> +++ b/package/udev/udev.mk
 Spenser> @@ -12,7 +12,7 @@ UDEV_LICENSE_FILES = COPYING
 Spenser>  UDEV_INSTALL_STAGING = YES
 
 Spenser>  # mq_getattr is in librt
 Spenser> -UDEV_CONF_ENV += LIBS=-lrt
 Spenser> +UDEV_CONF_ENV += LIBS="-lrt -lpthread"
 
 Spenser>  UDEV_CONF_OPT =			\
 Spenser>  	--sbindir=/sbin		\
 Spenser> -- 
 Spenser> 1.7.1

 Spenser> _______________________________________________
 Spenser> buildroot mailing list
 Spenser> buildroot@busybox.net
 Spenser> http://lists.busybox.net/mailman/listinfo/buildroot
Spenser Gilliland - Oct. 8, 2013, 2:55 p.m.
Peter,
>
>  Spenser> This fixes builds with Linaro hard float toolchains.
>
> Sorry, what toolchain exactly? I just did a test build with our default
> (Linaro 2013.08) ext toolchain, and didn't have any linker issues.

This has been occurring with the Linaro 2013.06 toolchain.  I'll test
with the 2013.08 toolchain.  I'm not sure why the 2013.06 was chosen
by default.

Thanks,
Spenser

Patch

diff --git a/package/udev/udev.mk b/package/udev/udev.mk
index db86850..b512ec5 100644
--- a/package/udev/udev.mk
+++ b/package/udev/udev.mk
@@ -12,7 +12,7 @@  UDEV_LICENSE_FILES = COPYING
 UDEV_INSTALL_STAGING = YES
 
 # mq_getattr is in librt
-UDEV_CONF_ENV += LIBS=-lrt
+UDEV_CONF_ENV += LIBS="-lrt -lpthread"
 
 UDEV_CONF_OPT =			\
 	--sbindir=/sbin		\