| Message ID | 1380227287-26057-6-git-send-email-trini@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On Thu, 2013-09-26 at 16:28 -0400, Tom Rini wrote: > Cc: Scott Wood <scottwood@freescale.com> > Signed-off-by: Tom Rini <trini@ti.com> > --- > drivers/mtd/nand/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile > index 366dee6..bb5b29d 100644 > --- a/drivers/mtd/nand/Makefile > +++ b/drivers/mtd/nand/Makefile > @@ -24,6 +24,7 @@ COBJS-$(CONFIG_SPL_NAND_LOAD) += nand_spl_load.o > COBJS-$(CONFIG_SPL_NAND_ECC) += nand_ecc.o > COBJS-$(CONFIG_SPL_NAND_BASE) += nand_base.o > COBJS-$(CONFIG_SPL_NAND_INIT) += nand.o > +COBJS-$(CONFIG_ENV_IS_IN_NAND) += nand_util.o Not all NAND SPLs will want this. Define a new CONFIG_SPL_* symbol, or perhaps it could just use CONFIG_SPL_NAND_BASE. -Scott
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/26/2013 04:42 PM, Scott Wood wrote: > On Thu, 2013-09-26 at 16:28 -0400, Tom Rini wrote: >> Cc: Scott Wood <scottwood@freescale.com> >> Signed-off-by: Tom Rini <trini@ti.com> >> --- >> drivers/mtd/nand/Makefile | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile >> index 366dee6..bb5b29d 100644 >> --- a/drivers/mtd/nand/Makefile >> +++ b/drivers/mtd/nand/Makefile >> @@ -24,6 +24,7 @@ COBJS-$(CONFIG_SPL_NAND_LOAD) += nand_spl_load.o >> COBJS-$(CONFIG_SPL_NAND_ECC) += nand_ecc.o >> COBJS-$(CONFIG_SPL_NAND_BASE) += nand_base.o >> COBJS-$(CONFIG_SPL_NAND_INIT) += nand.o >> +COBJS-$(CONFIG_ENV_IS_IN_NAND) += nand_util.o > > Not all NAND SPLs will want this. Define a new CONFIG_SPL_* symbol, or > perhaps it could just use CONFIG_SPL_NAND_BASE. Then they won't get it. Without CONFIG_SPL_ENV_SUPPORT that all gets discarded. And talked about before adding CONFIG_SPL_ENV_... and I didn't want to go down that path. If you feel strongly about not building the object we can guard this with CONFIG_SPL_ENV_SUPPORT checks perhaps? - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSRJz4AAoJENk4IS6UOR1WMfAP/RkD0fqs0QMaS+rXwrFtVSuk D3wH9KmvehSgY8AL1rq/gpNxFSj/t3/yqdMP6uE1RIJQjlcMsAhXalsy9+QSzDeq TInAA3gebJVOIJzvJlPEkaR4ybEdQOgtMzcWXqV0mrV626SXfNo6PQ8ZtGxBxAm3 oDBbJw0xkmkqnVgOy+jNDgoPoR8aNl1bbpB0UTb2Iz5rRghf0GYPVeR3J88+Fgtq cm0sQdklkl28ZnbJFU9uhL7Sdws23QuZBihIwiEwmMqwT1pI17nF/YGm3WaayGd3 Pb4wb+FyesDHIcTwl4fDDN+QMNFQ6oz/3lden6X7a/rPHJWxxxUFQtKFykIfExk3 YnPMud20TDlEHeRvoI4vqqvtBd2/nCjyw/R2UhMgyc0Uk+43lJUbXhiq9XbLk88t m5RZjsfLGTUl12Uxe5OIh+s8O1BkrmY+knyZSwy8uw0JZcnuuV11A15vNoCMNQzc vzzXCke8r0rS5Ci3ai2R6XGJX8Thh3QD3+ZYED899B2TwPxHH6wo6saLnNNf4nYt s41rExlhzCMDRSl3Kd1pnFIFu7butiRZWuRldTY/ASwAZKtvvUOibq9U23HtWwKY JSLlkkTjIOEsJPZcvPgooMHdJA1Kyt5Lb9SHpgkozqd1Dy0WPA/JOSfgoGoSRhKh tM0XMWkMuUYt1oNToTkl =n9Vw -----END PGP SIGNATURE-----
On Thu, 2013-09-26 at 16:45 -0400, Tom Rini wrote: > On 09/26/2013 04:42 PM, Scott Wood wrote: > > On Thu, 2013-09-26 at 16:28 -0400, Tom Rini wrote: > >> Cc: Scott Wood <scottwood@freescale.com> > >> Signed-off-by: Tom Rini <trini@ti.com> > >> --- > >> drivers/mtd/nand/Makefile | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile > >> index 366dee6..bb5b29d 100644 > >> --- a/drivers/mtd/nand/Makefile > >> +++ b/drivers/mtd/nand/Makefile > >> @@ -24,6 +24,7 @@ COBJS-$(CONFIG_SPL_NAND_LOAD) += nand_spl_load.o > >> COBJS-$(CONFIG_SPL_NAND_ECC) += nand_ecc.o > >> COBJS-$(CONFIG_SPL_NAND_BASE) += nand_base.o > >> COBJS-$(CONFIG_SPL_NAND_INIT) += nand.o > >> +COBJS-$(CONFIG_ENV_IS_IN_NAND) += nand_util.o > > > > Not all NAND SPLs will want this. Define a new CONFIG_SPL_* symbol, or > > perhaps it could just use CONFIG_SPL_NAND_BASE. > > Then they won't get it. Without CONFIG_SPL_ENV_SUPPORT that all gets > discarded. Anonymous strings won't. > And talked about before adding CONFIG_SPL_ENV_... and I > didn't want to go down that path. If you feel strongly about not > building the object we can guard this with CONFIG_SPL_ENV_SUPPORT checks > perhaps? And then we get a bigger mess if something wants nand_util for some other reason... I think the entire way SPL has been structured is a mistake, and it should have been viewed as just multiple U-Boot configs that happen to be automatically built and concatenated together under one user-visible target name. Then, if existing config mechanisms are not fine grained enough, make them finer grained. Bring in kconfig to sort out the dependency mess. -Scott
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/26/2013 04:51 PM, Scott Wood wrote: > On Thu, 2013-09-26 at 16:45 -0400, Tom Rini wrote: >> On 09/26/2013 04:42 PM, Scott Wood wrote: >>> On Thu, 2013-09-26 at 16:28 -0400, Tom Rini wrote: >>>> Cc: Scott Wood <scottwood@freescale.com> >>>> Signed-off-by: Tom Rini <trini@ti.com> >>>> --- >>>> drivers/mtd/nand/Makefile | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile >>>> index 366dee6..bb5b29d 100644 >>>> --- a/drivers/mtd/nand/Makefile >>>> +++ b/drivers/mtd/nand/Makefile >>>> @@ -24,6 +24,7 @@ COBJS-$(CONFIG_SPL_NAND_LOAD) += nand_spl_load.o >>>> COBJS-$(CONFIG_SPL_NAND_ECC) += nand_ecc.o >>>> COBJS-$(CONFIG_SPL_NAND_BASE) += nand_base.o >>>> COBJS-$(CONFIG_SPL_NAND_INIT) += nand.o >>>> +COBJS-$(CONFIG_ENV_IS_IN_NAND) += nand_util.o >>> >>> Not all NAND SPLs will want this. Define a new CONFIG_SPL_* symbol, or >>> perhaps it could just use CONFIG_SPL_NAND_BASE. >> >> Then they won't get it. Without CONFIG_SPL_ENV_SUPPORT that all gets >> discarded. > > Anonymous strings won't. Ah that's right, curses... >> And talked about before adding CONFIG_SPL_ENV_... and I >> didn't want to go down that path. If you feel strongly about not >> building the object we can guard this with CONFIG_SPL_ENV_SUPPORT checks >> perhaps? > > And then we get a bigger mess if something wants nand_util for some > other reason... > > I think the entire way SPL has been structured is a mistake, and it > should have been viewed as just multiple U-Boot configs that happen to > be automatically built and concatenated together under one user-visible > target name. Then, if existing config mechanisms are not fine grained > enough, make them finer grained. Bring in kconfig to sort out the > dependency mess. Mid-term, yes. I would like to talk about Kconfig more at ELC-E and get a feel from the community on how much time people have to devote to such big efforts. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSRKO+AAoJENk4IS6UOR1WMW8QAKUU8ZT2/W8EefntM4lQJ/iY /2PjdCPOA+KotWGPPCGyg6EjFFeNw03ruhnsDmtNduw2tWU6sq9WXZZoR3sw4kVP ZOax+kqxBrd8XBiqGzM5+3CD2W3KAiEYBwCbF2q9weG1U/Pl14rQEfAZ7RaXt7da Hz0mAhIKP+IyTJ94/SOvRCVziwJPNUYc1FL4hKnvA5knqkfmd36Jael1++1UxK15 eYp6o2Xdliz28mPL+It1UVUK9gn+3SDTOuG+KNNkCW+NSmB8hFMnVVTipZWc4u0H hQXquHVDGIUieZ7d1zbpcOkz5OVWcd+CjwvvbKPrMwvOHDNq9UbZo8QDtFFsnqZJ eSOOG6CVMdJ0t9TB6R1CKQaphtb6XQvKO6fStlQI07nXmDzdx9qHZjPeX8rH2aV0 xX7dAkIUpc5knpnb1r8SFVdawXqlveNgzYOEHCNVMk6kpsO1U0F53d7nzBXSOz6h d1zTR4xV91rWr1n9bp1YC9HML7c1InNo1gelKMNSjlUMWkg6mKEc+r9X70P0Qgx3 1kZ5GmR0HkvV1NnlYpgq09UvI+tWXIYcH4alEPge88JHEcEQHVhqzp9j5ErWt0ei 1VcIEA/s1Vj0RyBDolPeomnWv+liOm9RQaghBMwF7rDkd9pGbEytIfoyOb56cf3E WDs/54voOqB61z9+5c5f =ODSN -----END PGP SIGNATURE-----
diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile index 366dee6..bb5b29d 100644 --- a/drivers/mtd/nand/Makefile +++ b/drivers/mtd/nand/Makefile @@ -24,6 +24,7 @@ COBJS-$(CONFIG_SPL_NAND_LOAD) += nand_spl_load.o COBJS-$(CONFIG_SPL_NAND_ECC) += nand_ecc.o COBJS-$(CONFIG_SPL_NAND_BASE) += nand_base.o COBJS-$(CONFIG_SPL_NAND_INIT) += nand.o +COBJS-$(CONFIG_ENV_IS_IN_NAND) += nand_util.o else # not spl
Cc: Scott Wood <scottwood@freescale.com> Signed-off-by: Tom Rini <trini@ti.com> --- drivers/mtd/nand/Makefile | 1 + 1 file changed, 1 insertion(+)