From patchwork Thu Sep 26 11:18:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Sandoe X-Patchwork-Id: 278161 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B30312C00A2 for ; Thu, 26 Sep 2013 21:18:32 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; q=dns; s= default; b=guv+D5pIulSTM+O7S/sRQfBf/JEFsDmVJfDgrx+necV+Df4mX5ZYg 2QpFc0JH8Y8jWDRxyd54CVpB6abrpjbbiuQ84BvN4GIHayKmG98i6wkHQtyJIG2H zxlOP9wFrgpIetd3oK1vAAIgKYOM0Ixl59AMGtVw09005C5hDWAh/U= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=default; bh=3KD/qnMtaBGHJ7+800QPmNTHCgI=; b=n4oiwPDVOp1To5LHz+Vj5x4uKJXl rdssd6Vn2hIBHktZAQAnbgsT1yymWMTTn/Cr6EbyfILDFp1nuJPsTmvdqMqbh3Je Tw83X+72aSk9AO9dtlscSIAq52lFkZtxrOOPJfhMiA6iiL8HkrJzdE4vMOuNxXbH MGgL378S9H9J4rA= Received: (qmail 8614 invoked by alias); 26 Sep 2013 11:18:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 8601 invoked by uid 89); 26 Sep 2013 11:18:25 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Sep 2013 11:18:25 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.0 required=5.0 tests=AWL, BAYES_00, RDNS_NONE, SPAM_SUBJECT, SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VP9aO-0007NX-Sy from Iain_Sandoe@mentor.com ; Thu, 26 Sep 2013 04:18:20 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 26 Sep 2013 04:18:20 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Thu, 26 Sep 2013 12:18:18 +0100 Subject: Re: [PATCH, RTL] Prepare ARM build with LRA MIME-Version: 1.0 (Apple Message framework v1283) From: Iain Sandoe In-Reply-To: Date: Thu, 26 Sep 2013 12:18:15 +0100 CC: GCC Patches Message-ID: <99A90FCD-7F00-4FB3-9D26-3D971DFCE81A@codesourcery.com> References: To: Yvan Roux Hi Yvan, On 24 Sep 2013, at 09:29, Yvan Roux wrote: >> On 11 September 2013 21:08, Yvan Roux wrote: >>> Here is the new patch discussed in the other thread. >>> >>> Thanks >>> Yvan >>> >>> 2013-09-11 Yvan Roux >>> Vladimir Makarov >>> >>> * rtlanal.c (lsb_bitfield_op_p): New predicate for bitfield operations >>> from the least significant bit. >>> (strip_address_mutations): Add bitfield operations handling. >>> (shift_code_p): New predicate for shifting operations. >>> (must_be_index_p): Add shifting operations handling. >>> (set_address_index): Likewise. as discussed on irc, this part (applied as r202914) breaks bootstrap on powerpc-darwin9 (and, presumably, other BE targets) with a signed/unsigned compare error at rtlanal.c:5482 below is a trivial patch, which makes both parts of test signed. With this, bootstrap completes on powerpc-darwin9 - however, you might want to check that it still does what you intended. thanks Iain diff --git a/gcc/rtlanal.c b/gcc/rtlanal.c index 24cbcd2..0349bcc 100644 --- a/gcc/rtlanal.c +++ b/gcc/rtlanal.c @@ -5476,7 +5476,7 @@ lsb_bitfield_op_p (rtx x) if (GET_RTX_CLASS (GET_CODE (x)) == RTX_BITFIELD_OPS) { enum machine_mode mode = GET_MODE (XEXP (x, 0)); - unsigned HOST_WIDE_INT len = INTVAL (XEXP (x, 1)); + HOST_WIDE_INT len = INTVAL (XEXP (x, 1)); HOST_WIDE_INT pos = INTVAL (XEXP (x, 2)); return (pos == (BITS_BIG_ENDIAN ? GET_MODE_PRECISION (mode) - len : 0));