Patchwork powerpc/powernv: Reduce panic timeout from 180s to 10s

login
register
mail settings
Submitter Anton Blanchard
Date Sept. 26, 2013, 11:17 a.m.
Message ID <20130926211719.7b99740a@kryten>
Download mbox | patch
Permalink /patch/278160/
State Superseded
Headers show

Comments

Anton Blanchard - Sept. 26, 2013, 11:17 a.m.
We made this change to pseries in 2011 and I think it makes
sense to do the same on powernv.

Signed-off-by: Anton Blanchard <anton@samba.org>
---
Michael Ellerman - Oct. 1, 2013, 8:39 a.m.
On Thu, Sep 26, 2013 at 09:17:19PM +1000, Anton Blanchard wrote:
> 
> We made this change to pseries in 2011 and I think it makes
> sense to do the same on powernv.

I'd vote we set it to 10s for all 64-bit machines in
arch/powerpc/kernel/setup_64.c.

cheers
Scott Wood - Oct. 8, 2013, 9:52 p.m.
On Tue, 2013-10-01 at 18:39 +1000, Michael Ellerman wrote:
> On Thu, Sep 26, 2013 at 09:17:19PM +1000, Anton Blanchard wrote:
> > 
> > We made this change to pseries in 2011 and I think it makes
> > sense to do the same on powernv.
> 
> I'd vote we set it to 10s for all 64-bit machines in
> arch/powerpc/kernel/setup_64.c.

Why is 64-bit relevant?  And wouldn't such a short delay be a problem if
the crash is displayed on a monitor?

-Scott
Anton Blanchard - Oct. 8, 2013, 11:56 p.m.
> > > We made this change to pseries in 2011 and I think it makes
> > > sense to do the same on powernv.
> > 
> > I'd vote we set it to 10s for all 64-bit machines in
> > arch/powerpc/kernel/setup_64.c.
> 
> Why is 64-bit relevant?  And wouldn't such a short delay be a problem
> if the crash is displayed on a monitor?

That is why we made it pseries specific in the past. Almost all our
boxes are on a virtual console and the 3 minutes of pausing just hurt
our uptimes.

If other platform maintainers prefer to keep the 3 minute pause, then
we just change the PowerNV platform.

Anton

Patch

Index: b/arch/powerpc/platforms/powernv/setup.c
===================================================================
--- a/arch/powerpc/platforms/powernv/setup.c
+++ b/arch/powerpc/platforms/powernv/setup.c
@@ -37,6 +37,8 @@ 
 
 static void __init pnv_setup_arch(void)
 {
+	panic_timeout = 10;
+
 	/* Initialize SMP */
 	pnv_smp_init();