Patchwork [v3] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

login
register
mail settings
Submitter Mark Wu
Date Sept. 26, 2013, 1:57 a.m.
Message ID <1380160635-15715-1-git-send-email-wudxw@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/278082/
State New
Headers show

Comments

Mark Wu - Sept. 26, 2013, 1:57 a.m.
Now we have several qemu-ga commands not returning response on success.
It has been documented in qga/qapi-schema.json already. This patch exposes
the 'success-response' flag by extending 'guest-info' command. With this
change, the clients can handle the command response more flexibly.

Signed-off-by: Mark Wu <wudxw@linux.vnet.ibm.com>
---
Changes:
v3: 
	 1. treat cmd->options as a bitmask instead of single option (per Eric) 
	 2. rebase on the patch " Add interface to traverse the qmp command list
    by QmpCommand" to avoid the O(n2) problem (per Eric and Michael)
v2: 
    add the notation 'since 1.7' to the option 'success-response'
    (per Eric Blake's comments)

 qga/commands.c       | 1 +
 qga/qapi-schema.json | 5 ++++-
 2 files changed, 5 insertions(+), 1 deletion(-)
Eric Blake - Sept. 26, 2013, 11:42 a.m.
On 09/25/2013 07:57 PM, Mark Wu wrote:
> Now we have several qemu-ga commands not returning response on success.
> It has been documented in qga/qapi-schema.json already. This patch exposes
> the 'success-response' flag by extending 'guest-info' command. With this
> change, the clients can handle the command response more flexibly.
> 
> Signed-off-by: Mark Wu <wudxw@linux.vnet.ibm.com>
> ---
> Changes:
> v3: 
> 	 1. treat cmd->options as a bitmask instead of single option (per Eric) 
> 	 2. rebase on the patch " Add interface to traverse the qmp command list
>     by QmpCommand" to avoid the O(n2) problem (per Eric and Michael)
> v2: 
>     add the notation 'since 1.7' to the option 'success-response'
>     (per Eric Blake's comments)
> 
>  qga/commands.c       | 1 +
>  qga/qapi-schema.json | 5 ++++-
>  2 files changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>
Michael Roth - Sept. 27, 2013, 4:23 p.m.
Quoting Mark Wu (2013-09-25 20:57:15)
> Now we have several qemu-ga commands not returning response on success.
> It has been documented in qga/qapi-schema.json already. This patch exposes
> the 'success-response' flag by extending 'guest-info' command. With this
> change, the clients can handle the command response more flexibly.
> 
> Signed-off-by: Mark Wu <wudxw@linux.vnet.ibm.com>
> ---
> Changes:
> v3: 
>          1. treat cmd->options as a bitmask instead of single option (per Eric) 
>          2. rebase on the patch " Add interface to traverse the qmp command list
>     by QmpCommand" to avoid the O(n2) problem (per Eric and Michael)

As per other patch, please include something like qmp_has_success_response()
to avoid poking directly at cmd->options.

Looks good otherwise.

> v2: 
>     add the notation 'since 1.7' to the option 'success-response'
>     (per Eric Blake's comments)
> 
>  qga/commands.c       | 1 +
>  qga/qapi-schema.json | 5 ++++-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/qga/commands.c b/qga/commands.c
> index 602cd47..f70d0c4 100644
> --- a/qga/commands.c
> +++ b/qga/commands.c
> @@ -54,6 +54,7 @@ static void qmp_command_info(QmpCommand *cmd, void *opaque)
>      cmd_info = g_malloc0(sizeof(GuestAgentCommandInfo));
>      cmd_info->name = g_strdup(cmd->name);
>      cmd_info->enabled = cmd->enabled;
> +    cmd_info->success_response = !(cmd->options & QCO_NO_SUCCESS_RESP);
>      cmd_info_list = g_malloc0(sizeof(GuestAgentCommandInfoList));
>      cmd_info_list->value = cmd_info;
>      cmd_info_list->next = info->supported_commands;
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 7155b7a..245f968 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -141,10 +141,13 @@
>  #
>  # @enabled: whether command is currently enabled by guest admin
>  #
> +# @success-response: whether command returns a response on success
> +#                    (since 1.7)
> +#
>  # Since 1.1.0
>  ##
>  { 'type': 'GuestAgentCommandInfo',
> -  'data': { 'name': 'str', 'enabled': 'bool' } }
> +  'data': { 'name': 'str', 'enabled': 'bool', 'success-response': 'bool' } }
> 
>  ##
>  # @GuestAgentInfo
> -- 
> 1.8.3.1

Patch

diff --git a/qga/commands.c b/qga/commands.c
index 602cd47..f70d0c4 100644
--- a/qga/commands.c
+++ b/qga/commands.c
@@ -54,6 +54,7 @@  static void qmp_command_info(QmpCommand *cmd, void *opaque)
     cmd_info = g_malloc0(sizeof(GuestAgentCommandInfo));
     cmd_info->name = g_strdup(cmd->name);
     cmd_info->enabled = cmd->enabled;
+    cmd_info->success_response = !(cmd->options & QCO_NO_SUCCESS_RESP);
     cmd_info_list = g_malloc0(sizeof(GuestAgentCommandInfoList));
     cmd_info_list->value = cmd_info;
     cmd_info_list->next = info->supported_commands;
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 7155b7a..245f968 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -141,10 +141,13 @@ 
 #
 # @enabled: whether command is currently enabled by guest admin
 #
+# @success-response: whether command returns a response on success
+#                    (since 1.7)
+#
 # Since 1.1.0
 ##
 { 'type': 'GuestAgentCommandInfo',
-  'data': { 'name': 'str', 'enabled': 'bool' } }
+  'data': { 'name': 'str', 'enabled': 'bool', 'success-response': 'bool' } }
 
 ##
 # @GuestAgentInfo