From patchwork Thu Sep 26 01:23:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hao X-Patchwork-Id: 278056 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id 1E9DB2C037F for ; Thu, 26 Sep 2013 11:23:54 +1000 (EST) Received: from mail-pb0-x230.google.com (mail-pb0-x230.google.com [IPv6:2607:f8b0:400e:c01::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 701D22C0090 for ; Thu, 26 Sep 2013 11:23:24 +1000 (EST) Received: by mail-pb0-f48.google.com with SMTP id ma3so411505pbc.21 for ; Wed, 25 Sep 2013 18:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=kLjTmPElwyBYUBvFqCeFLjp6WW745kcSMXk/vfMpqV8=; b=xvLt+DouQsMd8CsFLfW9Z2Sji3hP4Eeap2dU5Rje2ubkHIYi6b5WRZdDCoP6VNMAN5 uGnxPyILzG0ioMFRBEAo21TAn3UH2dYGWKd1ExdScG+6737B4pf75by+6+lW5+h9cT1b ifsnDNohSVKbfGfAi9i1Kql4cTc8QEAwDxGoYThBfnhUobwNLMTL4HJ0of3HaMqsvQVi LemJ38RPaFt7dDGP1V26Sk8zssnOD/ErI79pl+13PsCJFXQlEDlMEFYn5P2V6giKucQW fVpz0ujFj/38VMBfQP3cV2IHroPfd2r9GpQdcmid07wEXuI6dGhmWtYetsMf7H0e3Kpl XBlQ== X-Received: by 10.68.132.103 with SMTP id ot7mr13459982pbb.158.1380158601536; Wed, 25 Sep 2013 18:23:21 -0700 (PDT) Received: from pek-khao-d1.corp.ad.wrs.com ([1.202.252.122]) by mx.google.com with ESMTPSA id xv2sm50534149pbb.39.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 25 Sep 2013 18:23:20 -0700 (PDT) Date: Thu, 26 Sep 2013 09:23:11 +0800 From: Kevin Hao To: Scott Wood Subject: Re: [PATCH v3 3/3] powerpc/85xx: use one kernel option for all the CoreNet_Generic boards Message-ID: <20130926012310.GB9209@pek-khao-d1.corp.ad.wrs.com> References: <1379991797-29222-1-git-send-email-haokexin@gmail.com> <1379991797-29222-4-git-send-email-haokexin@gmail.com> <1380062492.24959.123.camel@snotra.buserror.net> <20130925005843.GA20572@pek-khao-d1.corp.ad.wrs.com> <1380150683.24959.215.camel@snotra.buserror.net> MIME-Version: 1.0 In-Reply-To: <1380150683.24959.215.camel@snotra.buserror.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: linuxppc X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.16rc2 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Sep 25, 2013 at 06:11:23PM -0500, Scott Wood wrote: > On Wed, 2013-09-25 at 08:58 +0800, Kevin Hao wrote: > > On Tue, Sep 24, 2013 at 05:41:32PM -0500, Scott Wood wrote: > > > On Tue, 2013-09-24 at 11:03 +0800, Kevin Hao wrote: > > > > + and B4 QDS boards > > [...] > > > > > > Is there any difference between the 32-bit and 64-bit versions of this > > > config symbol, other than the help text? > > > > No. As you know some of these boards only support 32bit kernel and some of > > them only support 64bit kernel. It will definitely cause confusion when using > > only one kernel option for all these boards. So I divide this into two options > > (even the same name) for 32bit and 64bit respectively. > > You could just mention in the help text which boards are 32-bit, which > are 64-bit, and which can work with either. OK. How about this? arch/powerpc/platforms/85xx/Kconfig | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) Thanks, Kevin > > -Scott > > > diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig index 04456fb..4d46349 100644 --- a/arch/powerpc/platforms/85xx/Kconfig +++ b/arch/powerpc/platforms/85xx/Kconfig @@ -218,20 +218,6 @@ config GE_IMP3A This board is a 3U CompactPCI Single Board Computer with a Freescale P2020 processor. -config CORENET_GENERIC - bool "Freescale CoreNet Generic" - select DEFAULT_UIMAGE - select PPC_E500MC - select PHYS_64BIT - select SWIOTLB - select ARCH_REQUIRE_GPIOLIB - select GPIO_MPC8XXX - select HAS_RAPIDIO - select PPC_EPAPR_HV_PIC - help - This option enables support for the P2041 RDB, P3041 DS, P4080 DS, P5020 DS - and P5040 DS boards - config SGY_CTS1000 tristate "Servergy CTS-1000 support" select GPIOLIB @@ -257,8 +243,6 @@ config PPC_QEMU_E500 unset based on the emulated CPU (or actual host CPU in the case of KVM). -if PPC64 - config CORENET_GENERIC bool "Freescale CoreNet Generic" select DEFAULT_UIMAGE @@ -271,10 +255,14 @@ config CORENET_GENERIC select HAS_RAPIDIO select PPC_EPAPR_HV_PIC help - This option enables support for the P5020 DS, P5040 DS, T4240 QDS - and B4 QDS boards + This option enables support for the FSL CoreNet based boards. + For 32bit kernel, the following boards are supported: + P2041 RDB, P3041 DS and P4080 DS + For 64bit kernel, the following boards are supported: + T4240 QDS and B4 QDS + The following boards are supported for both 32bit and 64bit kernel: + P5020 DS and P5040 DS -endif endif # FSL_SOC_BOOKE config TQM85xx