diff mbox

spapr: increase temporary fdt buffer size

Message ID 1380002395-14600-1-git-send-email-aik@ozlabs.ru
State New
Headers show

Commit Message

Alexey Kardashevskiy Sept. 24, 2013, 5:59 a.m. UTC
At the moment the size of the buffer is set to 64K which is
enough for approximately 150 VCPUs which is not the limit.

This increases the buffer up to 256K which allows having
a tree for approximately 600 VCPUs which is way beyond the real
number we need.

As only the real size of the tree is copied to the guest, there
will be no impact on existing configurations.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 hw/ppc/spapr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mike Qiu Sept. 24, 2013, 10:05 a.m. UTC | #1
On 09/24/2013 01:59 PM, Alexey Kardashevskiy wrote:
> At the moment the size of the buffer is set to 64K which is
> enough for approximately 150 VCPUs which is not the limit.
>
> This increases the buffer up to 256K which allows having
> a tree for approximately 600 VCPUs which is way beyond the real
> number we need.
>
> As only the real size of the tree is copied to the guest, there
> will be no impact on existing configurations.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>   hw/ppc/spapr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 1bb76f1..063fe63 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -62,7 +62,7 @@
>    *
>    * We load our kernel at 4M, leaving space for SLOF initial image
>    */
> -#define FDT_MAX_SIZE            0x10000
> +#define FDT_MAX_SIZE            0x40000
>   #define RTAS_MAX_SIZE           0x10000
>   #define FW_MAX_SIZE             0x400000
>   #define FW_FILE_NAME            "slof.bin"
Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Alexander Graf Sept. 25, 2013, 2:55 p.m. UTC | #2
On 24.09.2013, at 12:05, mike wrote:

> On 09/24/2013 01:59 PM, Alexey Kardashevskiy wrote:
>> At the moment the size of the buffer is set to 64K which is
>> enough for approximately 150 VCPUs which is not the limit.
>> 
>> This increases the buffer up to 256K which allows having
>> a tree for approximately 600 VCPUs which is way beyond the real
>> number we need.
>> 
>> As only the real size of the tree is copied to the guest, there
>> will be no impact on existing configurations.
>> 
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>>  hw/ppc/spapr.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
>> index 1bb76f1..063fe63 100644
>> --- a/hw/ppc/spapr.c
>> +++ b/hw/ppc/spapr.c
>> @@ -62,7 +62,7 @@
>>   *
>>   * We load our kernel at 4M, leaving space for SLOF initial image
>>   */
>> -#define FDT_MAX_SIZE            0x10000
>> +#define FDT_MAX_SIZE            0x40000
>>  #define RTAS_MAX_SIZE           0x10000
>>  #define FW_MAX_SIZE             0x400000
>>  #define FW_FILE_NAME            "slof.bin"
> Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>

Signed-off-by is supposed to mean "this patch went through my hands". So are you trying to say that you wrote this patch? Or that you think it does "the right thing" in which case it should be "Acked-by" or "Reviewed-by":

  https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297


Alex
Alexander Graf Sept. 25, 2013, 3 p.m. UTC | #3
On 24.09.2013, at 07:59, Alexey Kardashevskiy wrote:

> At the moment the size of the buffer is set to 64K which is
> enough for approximately 150 VCPUs which is not the limit.
> 
> This increases the buffer up to 256K which allows having
> a tree for approximately 600 VCPUs which is way beyond the real
> number we need.
> 
> As only the real size of the tree is copied to the guest, there
> will be no impact on existing configurations.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Thanks, applied to ppc-next.


Alex
diff mbox

Patch

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 1bb76f1..063fe63 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -62,7 +62,7 @@ 
  *
  * We load our kernel at 4M, leaving space for SLOF initial image
  */
-#define FDT_MAX_SIZE            0x10000
+#define FDT_MAX_SIZE            0x40000
 #define RTAS_MAX_SIZE           0x10000
 #define FW_MAX_SIZE             0x400000
 #define FW_FILE_NAME            "slof.bin"