diff mbox

netfilter: nf_tables: fix basechain release

Message ID 1379985287-4118-1-git-send-email-pablo@netfilter.org
State Accepted
Headers show

Commit Message

Pablo Neira Ayuso Sept. 24, 2013, 1:14 a.m. UTC 
Base chains are containers of the chain object, kfree was
receiving the wrong memory address in that case.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 net/netfilter/nf_tables_api.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff mbox

Patch

diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index 91cba3b..f2d7f93 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -1004,10 +1004,11 @@  static void nf_tables_rcu_chain_destroy(struct rcu_head *head)
 
 	BUG_ON(chain->use > 0);
 
-	if (chain->flags & NFT_BASE_CHAIN)
+	if (chain->flags & NFT_BASE_CHAIN) {
 		free_percpu(nft_base_chain(chain)->stats);
-
-	kfree(chain);
+		kfree(nft_base_chain(chain));
+	} else
+		kfree(chain);
 }
 
 static int nf_tables_delchain(struct sock *nlsk, struct sk_buff *skb,