Patchwork remoteproc/davinci: drop needless devm_clk_put

login
register
mail settings
Submitter Uwe Kleine-König
Date Sept. 23, 2013, 4 p.m.
Message ID <1379952020-5941-1-git-send-email-u.kleine-koenig@pengutronix.de>
Download mbox | patch
Permalink /patch/277260/
State New
Headers show

Comments

Uwe Kleine-König - Sept. 23, 2013, 4 p.m.
The comment above disable_irq says that it is needed to ensure that the
"devm subsystem might end up releasing things before freeing the irq,
thus allowing an interrupt to sneak in while the device is being
removed." disable_irq is enough for this purpose and there is no need to
manually free the reference to the clock.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Cc: Robert Tivy <rtivy@ti.com>
---
 drivers/remoteproc/da8xx_remoteproc.c | 2 --
 1 file changed, 2 deletions(-)
Ohad Ben-Cohen - Feb. 24, 2014, 3:07 p.m.
On Mon, Sep 23, 2013 at 7:00 PM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> The comment above disable_irq says that it is needed to ensure that the
> "devm subsystem might end up releasing things before freeing the irq,
> thus allowing an interrupt to sneak in while the device is being
> removed." disable_irq is enough for this purpose and there is no need to
> manually free the reference to the clock.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Applied and pushed to remoteproc-next, thanks!

Patch

diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
index 129f7b9..b91cd30 100644
--- a/drivers/remoteproc/da8xx_remoteproc.c
+++ b/drivers/remoteproc/da8xx_remoteproc.c
@@ -301,8 +301,6 @@  static int da8xx_rproc_remove(struct platform_device *pdev)
 	 */
 	disable_irq(drproc->irq);
 
-	devm_clk_put(dev, drproc->dsp_clk);
-
 	rproc_del(rproc);
 	rproc_put(rproc);