diff mbox

qemu-iotests: Do not execute 052 with -nocache

Message ID 1379947113-12476-1-git-send-email-mreitz@redhat.com
State New
Headers show

Commit Message

Max Reitz Sept. 23, 2013, 2:38 p.m. UTC
Test 052 uses qemu-io -s which will result in bdrv_open trying to create
a temporary snapshot file in /tmp. However, since O_DIRECT and tmpfs
do not work well together, disable this test for -nocache.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/052 | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Hajnoczi Sept. 24, 2013, 11:32 a.m. UTC | #1
On Mon, Sep 23, 2013 at 04:38:33PM +0200, Max Reitz wrote:
> Test 052 uses qemu-io -s which will result in bdrv_open trying to create
> a temporary snapshot file in /tmp. However, since O_DIRECT and tmpfs
> do not work well together, disable this test for -nocache.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  tests/qemu-iotests/052 | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Kevin Wolf Sept. 24, 2013, 2:58 p.m. UTC | #2
Am 23.09.2013 um 16:38 hat Max Reitz geschrieben:
> Test 052 uses qemu-io -s which will result in bdrv_open trying to create
> a temporary snapshot file in /tmp. However, since O_DIRECT and tmpfs
> do not work well together, disable this test for -nocache.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>

Thanks, applied to the block branch.

Kevin
diff mbox

Patch

diff --git a/tests/qemu-iotests/052 b/tests/qemu-iotests/052
index 14a5126..49810cb 100755
--- a/tests/qemu-iotests/052
+++ b/tests/qemu-iotests/052
@@ -41,6 +41,7 @@  trap "_cleanup; exit \$status" 0 1 2 3 15
 _supported_fmt generic
 _supported_proto generic
 _supported_os Linux
+_unsupported_qemu_io_options --nocache
 
 
 size=128M