Patchwork [3/3] mtd/maps: uclinux: do not allow to be built as a module

login
register
mail settings
Submitter Mike Frysinger
Date May 26, 2009, 11:33 p.m.
Message ID <1243380798-10089-3-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/27720/
State Accepted
Commit 6ae392ccadbc622d58a9d01a7ee59e340f82fe85
Headers show

Comments

Mike Frysinger - May 26, 2009, 11:33 p.m.
There isn't any benefit to building the uClinux MTD map as a module as the
rootfs it requires in order to actually be usable is appended to the
kernel image, not the module.  No known system builds it this way either,
so change the option to "bool".

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
CC: Paul Mundt <lethal@linux-sh.org>
CC: Greg Ungerer <gerg@uclinux.org>
CC: uclinux-dev@uclinux.org
CC: linux-mtd@lists.infradead.org
---
 drivers/mtd/maps/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Greg Ungerer - June 10, 2009, 2:34 a.m.
Mike Frysinger wrote:
> There isn't any benefit to building the uClinux MTD map as a module as the
> rootfs it requires in order to actually be usable is appended to the
> kernel image, not the module.  No known system builds it this way either,
> so change the option to "bool".
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Paul Mundt <lethal@linux-sh.org>
> CC: Greg Ungerer <gerg@uclinux.org>

Acked-by: Greg Ungerer <gerg@uclinux.org>


> CC: uclinux-dev@uclinux.org
> CC: linux-mtd@lists.infradead.org
> ---
>  drivers/mtd/maps/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/maps/Kconfig b/drivers/mtd/maps/Kconfig
> index 82923bd..907873b 100644
> --- a/drivers/mtd/maps/Kconfig
> +++ b/drivers/mtd/maps/Kconfig
> @@ -501,7 +501,7 @@ config MTD_BFIN_ASYNC
>  	  If compiled as a module, it will be called bfin-async-flash.
>  
>  config MTD_UCLINUX
> -	tristate "Generic uClinux RAM/ROM filesystem support"
> +	bool "Generic uClinux RAM/ROM filesystem support"
>  	depends on MTD_PARTITIONS && MTD_RAM && !MMU
>  	help
>  	  Map driver to support image based filesystems for uClinux.

Patch

diff --git a/drivers/mtd/maps/Kconfig b/drivers/mtd/maps/Kconfig
index 82923bd..907873b 100644
--- a/drivers/mtd/maps/Kconfig
+++ b/drivers/mtd/maps/Kconfig
@@ -501,7 +501,7 @@  config MTD_BFIN_ASYNC
 	  If compiled as a module, it will be called bfin-async-flash.
 
 config MTD_UCLINUX
-	tristate "Generic uClinux RAM/ROM filesystem support"
+	bool "Generic uClinux RAM/ROM filesystem support"
 	depends on MTD_PARTITIONS && MTD_RAM && !MMU
 	help
 	  Map driver to support image based filesystems for uClinux.