Patchwork [v5,1/6] qapi: Add ImageInfoSpecific type

login
register
mail settings
Submitter Max Reitz
Date Sept. 23, 2013, 12:09 p.m.
Message ID <1379938162-14005-2-git-send-email-mreitz@redhat.com>
Download mbox | patch
Permalink /patch/277164/
State New
Headers show

Comments

Max Reitz - Sept. 23, 2013, 12:09 p.m.
Add a new type ImageInfoSpecific as a union for image format specific
information in ImageInfo.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 qapi-schema.json | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
Eric Blake - Sept. 30, 2013, 4:04 p.m.
On 09/23/2013 06:09 AM, Max Reitz wrote:
> Add a new type ImageInfoSpecific as a union for image format specific
> information in ImageInfo.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  qapi-schema.json | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)

> @@ -238,6 +250,9 @@
>  #
>  # @backing-image: #optional info of the backing image (since 1.6)
>  #
> +# @info-string: #optional string supplying additional format-specific

s/string/struct/

With that one word fixed, I'm fine with:

Reviewed-by: Eric Blake <eblake@redhat.com>

Patch

diff --git a/qapi-schema.json b/qapi-schema.json
index 145eca8..cbad705 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -210,6 +210,18 @@ 
             'vm-clock-sec': 'int', 'vm-clock-nsec': 'int' } }
 
 ##
+# @ImageInfoSpecific:
+#
+# A discriminated record of image format specific information structures.
+#
+# Since: 1.7
+##
+
+{ 'union': 'ImageInfoSpecific',
+  'data': {
+  } }
+
+##
 # @ImageInfo:
 #
 # Information about a QEMU image file
@@ -238,6 +250,9 @@ 
 #
 # @backing-image: #optional info of the backing image (since 1.6)
 #
+# @info-string: #optional string supplying additional format-specific
+# information (since 1.7)
+#
 # Since: 1.3
 #
 ##
@@ -248,7 +263,8 @@ 
            '*cluster-size': 'int', '*encrypted': 'bool',
            '*backing-filename': 'str', '*full-backing-filename': 'str',
            '*backing-filename-format': 'str', '*snapshots': ['SnapshotInfo'],
-           '*backing-image': 'ImageInfo' } }
+           '*backing-image': 'ImageInfo',
+           '*format-specific': 'ImageInfoSpecific' } }
 
 ##
 # @ImageCheck: