diff mbox

[1/4] mtd: intel_vr_nor: remove unnecessary pci_set_drvdata()

Message ID 002d01ceb7fc$6a5bdd50$3f1397f0$%han@samsung.com
State Accepted
Commit fe7feb9983dc4f5caadc72c11cee1f1162930533
Headers show

Commit Message

Jingoo Han Sept. 23, 2013, 1:29 a.m. UTC 
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/mtd/maps/intel_vr_nor.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Brian Norris Oct. 7, 2013, 6:34 p.m. UTC | #1 
On Sun, Sep 22, 2013 at 6:29 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Pushed all 4 to l2-mtd.git. Thanks!

Brian
diff mbox

Patch

diff --git a/drivers/mtd/maps/intel_vr_nor.c b/drivers/mtd/maps/intel_vr_nor.c
index f581ac1..46d195f 100644
--- a/drivers/mtd/maps/intel_vr_nor.c
+++ b/drivers/mtd/maps/intel_vr_nor.c
@@ -180,7 +180,6 @@  static void vr_nor_pci_remove(struct pci_dev *dev)
 {
 	struct vr_nor_mtd *p = pci_get_drvdata(dev);
 
-	pci_set_drvdata(dev, NULL);
 	vr_nor_destroy_partitions(p);
 	vr_nor_destroy_mtd_setup(p);
 	vr_nor_destroy_maps(p);