From patchwork Sat Sep 21 22:27:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Senna Tschudin X-Patchwork-Id: 276916 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-wi0-x23f.google.com (mail-wi0-x23f.google.com [IPv6:2a00:1450:400c:c05::23f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id A352C2C011B for ; Sun, 22 Sep 2013 08:29:08 +1000 (EST) Received: by mail-wi0-f191.google.com with SMTP id hn9sf116419wib.28 for ; Sat, 21 Sep 2013 15:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type; bh=HEubcTwZCr8Z9MKEky6AVoA9l5UHNIkideaX4sOo2Nc=; b=nuD94pcS2F2qkHqbC3pjjQwRMqqbZn4uXJZOEdk5Uu1r1kJx02JhAJf5c/VMUhLPfN D0G3oySA4NSAXRDbsS1M4hSgMYjkBqgZ98HqlCFJbZh9yLwK00JNpHP954Guk5OBLtCY lo2wdkPbQFyT1AY4KI+XFRGxHrTcIC7Kv6bE/QEKS0pPLLg5z+NI5jJ1A7mKFGnZxety 89Qi7SU+LDDa2jAonr071qnUd51tXqDlc4gisf3PUzxvpwTCM0K44S5jTk15OoMlIOu6 27hNaPBXYvB+Iowxl+P9D/gjwbHUPB0beT+Zbgsl57ZlAwRvMLh0BKhZI/d0cZI80+66 k5AA== X-Received: by 10.180.108.100 with SMTP id hj4mr292530wib.9.1379802544359; Sat, 21 Sep 2013 15:29:04 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.180.105.164 with SMTP id gn4ls401948wib.51.canary; Sat, 21 Sep 2013 15:29:03 -0700 (PDT) X-Received: by 10.180.208.67 with SMTP id mc3mr3928902wic.1.1379802543460; Sat, 21 Sep 2013 15:29:03 -0700 (PDT) Received: from mail-wi0-x22d.google.com (mail-wi0-x22d.google.com [2a00:1450:400c:c05::22d]) by gmr-mx.google.com with ESMTPS id p18si364680wiw.2.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 21 Sep 2013 15:29:03 -0700 (PDT) Received-SPF: pass (google.com: domain of peter.senna@gmail.com designates 2a00:1450:400c:c05::22d as permitted sender) client-ip=2a00:1450:400c:c05::22d; Received: by mail-wi0-x22d.google.com with SMTP id hq15so876162wib.6 for ; Sat, 21 Sep 2013 15:29:03 -0700 (PDT) X-Received: by 10.180.105.226 with SMTP id gp2mr7705162wib.6.1379802543396; Sat, 21 Sep 2013 15:29:03 -0700 (PDT) Received: from notepeter.home (210-232.80-90.static-ip.oleane.fr. [90.80.232.210]) by mx.google.com with ESMTPSA id iz19sm14891990wic.9.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 21 Sep 2013 15:29:02 -0700 (PDT) From: Peter Senna Tschudin To: a.zummo@towertech.it Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Peter Senna Tschudin Subject: [rtc-linux] [PATCH 13/19] rtc: Change variable type to bool Date: Sun, 22 Sep 2013 00:27:45 +0200 Message-Id: <1379802471-30252-13-git-send-email-peter.senna@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1379802471-30252-1-git-send-email-peter.senna@gmail.com> References: <1379802471-30252-1-git-send-email-peter.senna@gmail.com> X-Original-Sender: peter.senna@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of peter.senna@gmail.com designates 2a00:1450:400c:c05::22d as permitted sender) smtp.mail=peter.senna@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , The variable want_irq is only assigned the values true and false. Change its type to bool. The simplified semantic patch that find this problem is as follows (http://coccinelle.lip6.fr/): @exists@ type T; identifier b; @@ - T + bool b = ...; ... when any b = \(true\|false\) Signed-off-by: Peter Senna Tschudin --- drivers/rtc/rtc-ds1307.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index ca18fd1..c8babcf 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -670,7 +670,7 @@ static int ds1307_probe(struct i2c_client *client, int tmp; const struct chip_desc *chip = &chips[id->driver_data]; struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent); - int want_irq = false; + bool want_irq = false; unsigned char *buf; struct ds1307_platform_data *pdata = client->dev.platform_data; static const int bbsqi_bitpos[] = {