Patchwork xfstests: set umask to avoid spurious generic/314 test failures

login
register
mail settings
Submitter Eric Whitney
Date Sept. 21, 2013, 9:17 p.m.
Message ID <20130921211735.GC7855@wallace>
Download mbox | patch
Permalink /patch/276914/
State Not Applicable
Headers show

Comments

Eric Whitney - Sept. 21, 2013, 9:17 p.m.
Generic/314 can fail when the group write file mode bit for "subdir" does not
match that found in the golden output, as has been seen in ext4 regression
testing.  It appears that the golden output for generic/314 was taken on a
system where the $qa_user's umask cleared that mode bit - most likely, where
the umask was 022.  Depending upon the distro, it's not uncommon for a user's
default umask to have a different value, such as 002.  When that's the case,
we get a false negative failure when the group write mode bit for "subdir" is
not cleared.  This failure is unrelated to the value of the SGID mode bit
that is the object of this test.

We could either require that $qa_user's account be configured in advance with
a umask of 022, or explicitly set a umask value compatible with the golden
output when creating "subdir".  The latter option is more robust.

Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
 tests/generic/314 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 mode change 100644 => 100755 tests/generic/314
jeff.liu - Dec. 13, 2013, 4:06 a.m.
Hi Folks,

We missed this patch from Eric for a few months, I observed the same
false alarm while analyzing xfstests logs against our next tree...

Eric's fix works fine to me.

Thanks,
-Jeff

On 09/22 2013 05:17 AM, Eric Whitney wrote:
> Generic/314 can fail when the group write file mode bit for "subdir" does not
> match that found in the golden output, as has been seen in ext4 regression
> testing.  It appears that the golden output for generic/314 was taken on a
> system where the $qa_user's umask cleared that mode bit - most likely, where
> the umask was 022.  Depending upon the distro, it's not uncommon for a user's
> default umask to have a different value, such as 002.  When that's the case,
> we get a false negative failure when the group write mode bit for "subdir" is
> not cleared.  This failure is unrelated to the value of the SGID mode bit
> that is the object of this test.
> 
> We could either require that $qa_user's account be configured in advance with
> a umask of 022, or explicitly set a umask value compatible with the golden
> output when creating "subdir".  The latter option is more robust.
> 
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
> ---
>  tests/generic/314 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  mode change 100644 => 100755 tests/generic/314
> 
> diff --git a/tests/generic/314 b/tests/generic/314
> old mode 100644
> new mode 100755
> index 0dd98a3..f430b82
> --- a/tests/generic/314
> +++ b/tests/generic/314
> @@ -57,7 +57,7 @@ chown $qa_user:12345 $TEST_DIR/$seq-dir
>  chmod 2775 $TEST_DIR/$seq-dir
>  
>  # Make subdirs before & after acl set
> -su $qa_user -c "mkdir $TEST_DIR/$seq-dir/subdir"
> +su $qa_user -c "umask 022; mkdir $TEST_DIR/$seq-dir/subdir"
>  su $qa_user -c "setfacl -m u:$qa_user:rwx,d:u:$qa_user:rwx $TEST_DIR/$seq-dir"
>  su $qa_user -c "mkdir $TEST_DIR/$seq-dir/subdir2"
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Christoph Hellwig - Dec. 13, 2013, 11:17 a.m.
Looks good to me too,

Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rich Johnston - Dec. 17, 2013, 4:39 p.m.
This patch has been committed.

Thanks
--Rich

commit d0b5b6f9a8ccdb1279f319866e4540e8a05ac7c4
Author: Eric Whitney <enwlinux@gmail.com>
Date:   Sat Sep 21 21:17:35 2013 +0000

     xfstests: set umask to avoid spurious generic/314 test failures
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/tests/generic/314 b/tests/generic/314
old mode 100644
new mode 100755
index 0dd98a3..f430b82
--- a/tests/generic/314
+++ b/tests/generic/314
@@ -57,7 +57,7 @@  chown $qa_user:12345 $TEST_DIR/$seq-dir
 chmod 2775 $TEST_DIR/$seq-dir
 
 # Make subdirs before & after acl set
-su $qa_user -c "mkdir $TEST_DIR/$seq-dir/subdir"
+su $qa_user -c "umask 022; mkdir $TEST_DIR/$seq-dir/subdir"
 su $qa_user -c "setfacl -m u:$qa_user:rwx,d:u:$qa_user:rwx $TEST_DIR/$seq-dir"
 su $qa_user -c "mkdir $TEST_DIR/$seq-dir/subdir2"