Patchwork powerpc/85xx: add nor flash partitions for mpc8569mds

login
register
mail settings
Submitter Kevin Hao
Date May 27, 2009, 2:05 a.m.
Message ID <1243389905.13410.6.camel@kevin>
Download mbox | patch
Permalink /patch/27691/
State Accepted
Commit 40aa7353355f2d2766b2c960aff2f93e3dac4bfa
Delegated to: Kumar Gala
Headers show

Comments

Kevin Hao - May 27, 2009, 2:05 a.m.
Add 4 partitions in nor flash. Also fix nor flash
bank width bug.

Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
---
 arch/powerpc/boot/dts/mpc8569mds.dts |   24 +++++++++++++++++++++++-
 1 files changed, 23 insertions(+), 1 deletions(-)
Kumar Gala - June 11, 2009, 2:20 a.m.
On May 26, 2009, at 9:05 PM, Kevin Hao wrote:

> Add 4 partitions in nor flash. Also fix nor flash
> bank width bug.

Can you explain this.. I'm trying to understand why you set the bank- 
width to 1

- k

>
>
> Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
> ---
> arch/powerpc/boot/dts/mpc8569mds.dts |   24 +++++++++++++++++++++++-
> 1 files changed, 23 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/ 
> boot/dts/mpc8569mds.dts
> index 39c2927..1f98990 100644
> --- a/arch/powerpc/boot/dts/mpc8569mds.dts
> +++ b/arch/powerpc/boot/dts/mpc8569mds.dts
> @@ -70,8 +70,30 @@
> 			#size-cells = <1>;
> 			compatible = "cfi-flash";
> 			reg = <0x0 0x0 0x02000000>;
> -			bank-width = <2>;
> +			bank-width = <1>;
> 			device-width = <1>;
> +			partition@0 {
> +				label = "ramdisk";
> +				reg = <0x00000000 0x01c00000>;
> +			};
> +			partition@1c00000 {
> +				label = "kernel";
> +				reg = <0x01c00000 0x002e0000>;
> +			};
> +			partiton@1ee0000 {
> +				label = "dtb";
> +				reg = <0x01ee0000 0x00020000>;
> +			};
> +			partition@1f00000 {
> +				label = "firmware";
> +				reg = <0x01f00000 0x00080000>;
> +				read-only;
> +			};
> +			partition@1f80000 {
> +				label = "u-boot";
> +				reg = <0x01f80000 0x00080000>;
> +				read-only;
> +			};
> 		};
>
> 		bcsr@1,0 {
> -- 
> 1.6.0.4.771.gef3b3
Kevin Hao - June 11, 2009, 10:27 a.m.
On Wed, 2009-06-10 at 21:20 -0500, Kumar Gala wrote:
> On May 26, 2009, at 9:05 PM, Kevin Hao wrote:
> 
> > Add 4 partitions in nor flash. Also fix nor flash
> > bank width bug.
> 
> Can you explain this.. I'm trying to understand why you set the bank- 
> width to 1

The NOR flash (S29GL256N) works in 8-bit mode. And it's also not
interleaved. So the bank-width should be equal to device-width. If we
set bank-width to 2 the flash can not work correctly.

Thanks,
Kevin

> 
> - k
> 
> >
> >
> > Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
> > ---
> > arch/powerpc/boot/dts/mpc8569mds.dts |   24 +++++++++++++++++++++++-
> > 1 files changed, 23 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/ 
> > boot/dts/mpc8569mds.dts
> > index 39c2927..1f98990 100644
> > --- a/arch/powerpc/boot/dts/mpc8569mds.dts
> > +++ b/arch/powerpc/boot/dts/mpc8569mds.dts
> > @@ -70,8 +70,30 @@
> > 			#size-cells = <1>;
> > 			compatible = "cfi-flash";
> > 			reg = <0x0 0x0 0x02000000>;
> > -			bank-width = <2>;
> > +			bank-width = <1>;
> > 			device-width = <1>;
> > +			partition@0 {
> > +				label = "ramdisk";
> > +				reg = <0x00000000 0x01c00000>;
> > +			};
> > +			partition@1c00000 {
> > +				label = "kernel";
> > +				reg = <0x01c00000 0x002e0000>;
> > +			};
> > +			partiton@1ee0000 {
> > +				label = "dtb";
> > +				reg = <0x01ee0000 0x00020000>;
> > +			};
> > +			partition@1f00000 {
> > +				label = "firmware";
> > +				reg = <0x01f00000 0x00080000>;
> > +				read-only;
> > +			};
> > +			partition@1f80000 {
> > +				label = "u-boot";
> > +				reg = <0x01f80000 0x00080000>;
> > +				read-only;
> > +			};
> > 		};
> >
> > 		bcsr@1,0 {
> > -- 
> > 1.6.0.4.771.gef3b3
>
Kumar Gala - June 11, 2009, 2:06 p.m.
On May 26, 2009, at 9:05 PM, Kevin Hao wrote:

> Add 4 partitions in nor flash. Also fix nor flash
> bank width bug.
>
> Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
> ---
> arch/powerpc/boot/dts/mpc8569mds.dts |   24 +++++++++++++++++++++++-
> 1 files changed, 23 insertions(+), 1 deletions(-)

applied to next

- k

Patch

diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boot/dts/mpc8569mds.dts
index 39c2927..1f98990 100644
--- a/arch/powerpc/boot/dts/mpc8569mds.dts
+++ b/arch/powerpc/boot/dts/mpc8569mds.dts
@@ -70,8 +70,30 @@ 
 			#size-cells = <1>;
 			compatible = "cfi-flash";
 			reg = <0x0 0x0 0x02000000>;
-			bank-width = <2>;
+			bank-width = <1>;
 			device-width = <1>;
+			partition@0 {
+				label = "ramdisk";
+				reg = <0x00000000 0x01c00000>;
+			};
+			partition@1c00000 {
+				label = "kernel";
+				reg = <0x01c00000 0x002e0000>;
+			};
+			partiton@1ee0000 {
+				label = "dtb";
+				reg = <0x01ee0000 0x00020000>;
+			};
+			partition@1f00000 {
+				label = "firmware";
+				reg = <0x01f00000 0x00080000>;
+				read-only;
+			};
+			partition@1f80000 {
+				label = "u-boot";
+				reg = <0x01f80000 0x00080000>;
+				read-only;
+			};
 		};
 
 		bcsr@1,0 {