diff mbox

[U-Boot,2/3] mx28evk: Propagate the error if cpu_eth_init() fails

Message ID 1379705450-14684-2-git-send-email-festevam@gmail.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam Sept. 20, 2013, 7:30 p.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

If cpu_eth_init() fails we should return the error immediately.

Cc: Marek Vasut <marex@denx.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/denx/m28evk/m28evk.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Marek Vasut Sept. 22, 2013, 11:59 p.m. UTC | #1 
Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> If cpu_eth_init() fails we should return the error immediately.
> 
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Marek Vasut <marex@denx.de>

> ---
>  board/denx/m28evk/m28evk.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/board/denx/m28evk/m28evk.c b/board/denx/m28evk/m28evk.c
> index f4453d6..33d38cf 100644
> --- a/board/denx/m28evk/m28evk.c
> +++ b/board/denx/m28evk/m28evk.c
> @@ -116,6 +116,8 @@ int board_eth_init(bd_t *bis)
>  	int ret;
> 
>  	ret = cpu_eth_init(bis);
> +	if (ret)
> +		return ret;
> 
>  	clrsetbits_le32(&clkctrl_regs->hw_clkctrl_enet,
>  		CLKCTRL_ENET_TIME_SEL_MASK | CLKCTRL_ENET_CLK_OUT_EN,

Best regards,
Marek Vasut
Stefano Babic Sept. 27, 2013, 12:04 p.m. UTC | #2 
On 20/09/2013 21:30, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> If cpu_eth_init() fails we should return the error immediately.
> 
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx (fix), thanks!

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/board/denx/m28evk/m28evk.c b/board/denx/m28evk/m28evk.c
index f4453d6..33d38cf 100644
--- a/board/denx/m28evk/m28evk.c
+++ b/board/denx/m28evk/m28evk.c
@@ -116,6 +116,8 @@  int board_eth_init(bd_t *bis)
 	int ret;
 
 	ret = cpu_eth_init(bis);
+	if (ret)
+		return ret;
 
 	clrsetbits_le32(&clkctrl_regs->hw_clkctrl_enet,
 		CLKCTRL_ENET_TIME_SEL_MASK | CLKCTRL_ENET_CLK_OUT_EN,