Patchwork [v2,2/6] sysvinit: depend on SysV selected as init system.

login
register
mail settings
Submitter Eric Le Bihan
Date Sept. 20, 2013, 12:24 p.m.
Message ID <1379679847-16141-3-git-send-email-eric.le.bihan.dev@free.fr>
Download mbox | patch
Permalink /patch/276416/
State Accepted
Commit 3124d6a47284e0a70da19241dfe4671b5b2bbbb8
Headers show

Comments

Eric Le Bihan - Sept. 20, 2013, 12:24 p.m.
In order to prevent sysvinit and systemd to be selected at the same
time, sysvinit can now only be selected if SysV is chosen as init
system.

Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
---
 package/sysvinit/Config.in |    1 +
 1 file changed, 1 insertion(+)

--
1.7.9.5
Thomas Petazzoni - Nov. 2, 2013, 6:07 p.m.
Dear Eric Le Bihan,

On Fri, 20 Sep 2013 14:24:03 +0200, Eric Le Bihan wrote:
> In order to prevent sysvinit and systemd to be selected at the same
> time, sysvinit can now only be selected if SysV is chosen as init
> system.
> 
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> ---
>  package/sysvinit/Config.in |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/sysvinit/Config.in b/package/sysvinit/Config.in
> index 34ec391..d91c643 100644
> --- a/package/sysvinit/Config.in
> +++ b/package/sysvinit/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_SYSVINIT
>  	bool "sysvinit"
> +	depends on BR2_INIT_SYSV
>  	help
>  	  /sbin/init - parent of all processes

Hum, isn't this causing a circular dependency?

BR2_INIT_SYSV selects BR2_PACKAGE_SYSVINIT
BR2_PACKAGE_SYSVINIT depends on BR2_INIT_SYSV

but apparently, Kconfig doesn't complain, so it looks fine to me:

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thomas

Patch

diff --git a/package/sysvinit/Config.in b/package/sysvinit/Config.in
index 34ec391..d91c643 100644
--- a/package/sysvinit/Config.in
+++ b/package/sysvinit/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_SYSVINIT
 	bool "sysvinit"
+	depends on BR2_INIT_SYSV
 	help
 	  /sbin/init - parent of all processes