| Message ID | a2b05987569c1439422b.1379587636@argentina |
|---|---|
| State | Superseded |
| Headers | show |
Dear Thomas De Schampheleire, On Thu, 19 Sep 2013 12:47:16 +0200, Thomas De Schampheleire wrote: > The output extension and the generation messages refer to 'text', but the make > target was confusingly 'txt'. This patch changes the make target for > consistency. > > Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> That's a change in the Buildroot interface, but I believe it's ok. However, you're not updating another occurrence of manual-txt in the main Makefile (see the release target). Thanks, Thomas
Hi Thomas, On Thu, Sep 19, 2013 at 5:40 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Thomas De Schampheleire, > > On Thu, 19 Sep 2013 12:47:16 +0200, Thomas De Schampheleire wrote: >> The output extension and the generation messages refer to 'text', but the make >> target was confusingly 'txt'. This patch changes the make target for >> consistency. >> >> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> > > That's a change in the Buildroot interface, but I believe it's ok. True. I figured that the manual is built only rarely (many people are using the release tarballs), let alone that manual-txt is explicitly called. People that do build manual-txt are often buildroot developers, and hopefully they are flexible enough :-) > However, you're not updating another occurrence of manual-txt in the > main Makefile (see the release target). Ai, sorry, I didn't think of that. Will fix. Thanks for your feedback, Thomas
diff --git a/Makefile b/Makefile --- a/Makefile +++ b/Makefile @@ -815,7 +815,7 @@ endif @echo ' manual-html - build manual in HTML' @echo ' manual-split-html - build manual in split HTML' @echo ' manual-pdf - build manual in PDF' - @echo ' manual-txt - build manual in txt' + @echo ' manual-text - build manual in text' @echo ' manual-epub - build manual in ePub' @echo @echo 'Miscellaneous:' diff --git a/docs/manual/manual.mk b/docs/manual/manual.mk --- a/docs/manual/manual.mk +++ b/docs/manual/manual.mk @@ -56,7 +56,7 @@ define GENDOC $(call GENDOC_INNER,$(1),xhtml,html,html,HTML,--xsltproc-opts "--stringparam toc.section.depth 4") $(call GENDOC_INNER,$(1),chunked,split-html,chunked,split HTML,--xsltproc-opts "--stringparam toc.section.depth 4") $(call GENDOC_INNER,$(1),pdf,pdf,pdf,PDF,--dblatex-opts "-P latex.output.revhistory=0") -$(call GENDOC_INNER,$(1),text,txt,text,text) +$(call GENDOC_INNER,$(1),text,text,text,text) $(call GENDOC_INNER,$(1),epub,epub,epub,ePUB) clean: $(1)-clean $(1)-clean:
The output extension and the generation messages refer to 'text', but the make target was confusingly 'txt'. This patch changes the make target for consistency. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> --- docs/manual/manual.mk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)