diff mbox

[2/2] qemu-kvm: paravirt: add feature kvm_pv_unhalt

Message ID 1379515305-8450-3-git-send-email-drjones@redhat.com
State New
Headers show

Commit Message

Andrew Jones Sept. 18, 2013, 2:41 p.m. UTC
I don't know yet if want this feature on by default, so for now I'm
just adding support for "-cpu ...,+kvm_pv_unhalt".

Signed-off-by: Andrew Jones <drjones@redhat.com>
---
 target-i386/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eduardo Habkost Sept. 18, 2013, 5:24 p.m. UTC | #1
On Wed, Sep 18, 2013 at 04:41:45PM +0200, Andrew Jones wrote:
> I don't know yet if want this feature on by default, so for now I'm
> just adding support for "-cpu ...,+kvm_pv_unhalt".
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>

Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

> ---
>  target-i386/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 42c5de034ecc8..89491e7b1fba1 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -123,7 +123,7 @@ static const char *ext4_feature_name[] = {
>  
>  static const char *kvm_feature_name[] = {
>      "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock",
> -    "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", NULL,
> +    "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", "kvm_pv_unhalt",
>      NULL, NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
> -- 
> 1.8.1.4
>
Andreas Färber Sept. 18, 2013, 5:35 p.m. UTC | #2
Am 18.09.2013 16:41, schrieb Andrew Jones:
> I don't know yet if want this feature on by default, so for now I'm
> just adding support for "-cpu ...,+kvm_pv_unhalt".
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  target-i386/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 42c5de034ecc8..89491e7b1fba1 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -123,7 +123,7 @@ static const char *ext4_feature_name[] = {
>  
>  static const char *kvm_feature_name[] = {
>      "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock",
> -    "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", NULL,
> +    "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", "kvm_pv_unhalt",
>      NULL, NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,

Since there's linux-headers updates involved I can't take it through my
qom-cpu queue. If Paolo can tweak the subject to "target-i386: Add
paravirt CPU feature kvm_pv_unhalt" or so I'd be happy for this to go
through his uq/master queue. (qemu-kvm no longer exists, all QEMU
patches are about QEMU anyway and there's no discrete "paravirt"
subsystem or precedent in qemu.git history.)

Patch itself is

Reviewed-by: Andreas Färber <afaerber@suse.de>

Regards,
Andreas
Paolo Bonzini Sept. 19, 2013, 5:35 p.m. UTC | #3
Il 18/09/2013 19:35, Andreas Färber ha scritto:
> Am 18.09.2013 16:41, schrieb Andrew Jones:
>> I don't know yet if want this feature on by default, so for now I'm
>> just adding support for "-cpu ...,+kvm_pv_unhalt".
>>
>> Signed-off-by: Andrew Jones <drjones@redhat.com>
>> ---
>>  target-i386/cpu.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
>> index 42c5de034ecc8..89491e7b1fba1 100644
>> --- a/target-i386/cpu.c
>> +++ b/target-i386/cpu.c
>> @@ -123,7 +123,7 @@ static const char *ext4_feature_name[] = {
>>  
>>  static const char *kvm_feature_name[] = {
>>      "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock",
>> -    "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", NULL,
>> +    "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", "kvm_pv_unhalt",
>>      NULL, NULL, NULL, NULL,
>>      NULL, NULL, NULL, NULL,
>>      NULL, NULL, NULL, NULL,
> 
> Since there's linux-headers updates involved I can't take it through my
> qom-cpu queue. If Paolo can tweak the subject to "target-i386: Add
> paravirt CPU feature kvm_pv_unhalt" or so I'd be happy for this to go
> through his uq/master queue. (qemu-kvm no longer exists, all QEMU
> patches are about QEMU anyway and there's no discrete "paravirt"
> subsystem or precedent in qemu.git history.)
> 
> Patch itself is
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Regards,
> Andreas
> 

Will do.

Paolo
diff mbox

Patch

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 42c5de034ecc8..89491e7b1fba1 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -123,7 +123,7 @@  static const char *ext4_feature_name[] = {
 
 static const char *kvm_feature_name[] = {
     "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock",
-    "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", NULL,
+    "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", "kvm_pv_unhalt",
     NULL, NULL, NULL, NULL,
     NULL, NULL, NULL, NULL,
     NULL, NULL, NULL, NULL,