| Message ID | 1379510464-25420-1-git-send-email-aida.mynzhasova@skitlab.ru |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 9/18/2013 4:21 PM, Aida Mynzhasova wrote: > IEEE 1588 timer reference clock source is determined through hard-coded > value in gianfar_ptp driver by default. This patch allows to select ptp > clock source by means of device tree file node. > > For instance: > > fsl,cksel = <0>; > Has this device tree binding been defined? (Where?) I don't see this property in the net-next.git tree at least. Claudiu -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Sep 18, 2013 at 05:21:04PM +0400, Aida Mynzhasova wrote: > IEEE 1588 timer reference clock source is determined through hard-coded > value in gianfar_ptp driver by default. This patch allows to select ptp > clock source by means of device tree file node. > > For instance: > > fsl,cksel = <0>; > > for using external (TSEC_TMR_CLK input) high precision timer > reference clock. > > Other acceptable values: > > <1> : eTSEC system clock > <2> : eTSEC1 transmit clock > <3> : RTC clock input Do the other clock sources even work at all? We were not able to get them working. Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 18.09.2013 19:44, Claudiu Manoil wrote: > > On 9/18/2013 4:21 PM, Aida Mynzhasova wrote: >> IEEE 1588 timer reference clock source is determined through hard-coded >> value in gianfar_ptp driver by default. This patch allows to select ptp >> clock source by means of device tree file node. >> >> For instance: >> >> fsl,cksel = <0>; >> > > Has this device tree binding been defined? (Where?) > I don't see this property in the net-next.git tree at least. > > Claudiu > > Hi Claudiu, actually, I don't know where I should define this binding, my only idea is to add "cksel" property description in /Documentation/devicetree/bindings/net/fsl-tsec-phy.txt. Am I right or I need to do some additional changes? Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 18.09.2013 20:08, Richard Cochran wrote: > On Wed, Sep 18, 2013 at 05:21:04PM +0400, Aida Mynzhasova wrote: >> IEEE 1588 timer reference clock source is determined through hard-coded >> value in gianfar_ptp driver by default. This patch allows to select ptp >> clock source by means of device tree file node. >> >> For instance: >> >> fsl,cksel = <0>; >> >> for using external (TSEC_TMR_CLK input) high precision timer >> reference clock. >> >> Other acceptable values: >> >> <1> : eTSEC system clock >> <2> : eTSEC1 transmit clock >> <3> : RTC clock input > > Do the other clock sources even work at all? > > We were not able to get them working. > > Thanks, > Richard > Hi Richard, I've tried to use 2 clock sources: external from TSEC_TMR_CLK input (for this I had to update multiplexer settings in uboot) and eTSEC system clock - counter worked fine with both. My attempts to use eTSEC1 transmit clock and RTC clock were unsuccessful (the system hanged up) irrespective of using hard-coded value or entry in dts file. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 9/18/2013 7:39 PM, Aida Mynzhasova wrote: > On 18.09.2013 19:44, Claudiu Manoil wrote: >> >> On 9/18/2013 4:21 PM, Aida Mynzhasova wrote: >>> IEEE 1588 timer reference clock source is determined through hard-coded >>> value in gianfar_ptp driver by default. This patch allows to select ptp >>> clock source by means of device tree file node. >>> >>> For instance: >>> >>> fsl,cksel = <0>; >>> >> >> Has this device tree binding been defined? (Where?) >> I don't see this property in the net-next.git tree at least. >> >> Claudiu >> >> > > Hi Claudiu, > > actually, I don't know where I should define this binding, my only idea > is to add "cksel" property description in > /Documentation/devicetree/bindings/net/fsl-tsec-phy.txt. Am I right or I > need to do some additional changes? > > Thanks. > > If you ask me, updates for the device trees of several powerpc boards, like the 83xx series (as this patch implies), should be discussed and agreed upon on the powerpc list (linuxppc-dev@lists.ozlabs.org), where these kind of changes are usually being discussed with people more knowledgeable in device tree bindings and the powerpc/83xx hardware. Regards, Claudiu -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Sep 19, 2013 at 07:30:02PM +0300, Claudiu Manoil wrote: > > If you ask me, updates for the device trees of several powerpc > boards, like the 83xx series (as this patch implies), should be > discussed and agreed upon on the powerpc list (linuxppc-dev@lists.ozlabs.org), > where these kind of changes are usually being discussed with people more > knowledgeable in device tree bindings and the powerpc/83xx hardware. Yes, and also CC the devicetree list. The original device tree attributes for the gianfar eTSEC timer functions were reviewed on all three lists. Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/freescale/gianfar_ptp.c b/drivers/net/ethernet/freescale/gianfar_ptp.c index 098f133..e006a09 100644 --- a/drivers/net/ethernet/freescale/gianfar_ptp.c +++ b/drivers/net/ethernet/freescale/gianfar_ptp.c @@ -452,7 +452,9 @@ static int gianfar_ptp_probe(struct platform_device *dev) err = -ENODEV; etsects->caps = ptp_gianfar_caps; - etsects->cksel = DEFAULT_CKSEL; + + if (get_of_u32(node, "fsl,cksel", &etsects->cksel)) + etsects->cksel = DEFAULT_CKSEL; if (get_of_u32(node, "fsl,tclk-period", &etsects->tclk_period) || get_of_u32(node, "fsl,tmr-prsc", &etsects->tmr_prsc) ||
IEEE 1588 timer reference clock source is determined through hard-coded value in gianfar_ptp driver by default. This patch allows to select ptp clock source by means of device tree file node. For instance: fsl,cksel = <0>; for using external (TSEC_TMR_CLK input) high precision timer reference clock. Other acceptable values: <1> : eTSEC system clock <2> : eTSEC1 transmit clock <3> : RTC clock input Signed-off-by: Aida Mynzhasova <aida.mynzhasova@skitlab.ru> --- drivers/net/ethernet/freescale/gianfar_ptp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)