Message ID | 1379464836-11402-1-git-send-email-guilherme.maciel.ferreira@gmail.com |
---|---|
State | Superseded |
Delegated to: | Tom Rini |
Headers | show |
Hi, On Tue, Sep 17, 2013 at 6:40 PM, <guilherme.maciel.ferreira@gmail.com>wrote: > From: Guilherme Maciel Ferreira <guilherme.maciel.ferreira@gmail.com> > > Signed-off-by: Guilherme Maciel Ferreira < > guilherme.maciel.ferreira@gmail.com> > --- > tools/mkimage.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/mkimage.c b/tools/mkimage.c > index 7f22101..08aa634 100644 > --- a/tools/mkimage.c > +++ b/tools/mkimage.c > @@ -632,8 +632,8 @@ copy_file (int ifd, const char *datafile, int pad) > (void) close (dfd); > } > > -void > -usage () > +static void > +usage (void) > How about: static void usage(void) i.e. put it on the same line and remove the space before ( > { > fprintf (stderr, "Usage: %s -l image\n" > " -l ==> list image header > information\n", > './tools/patman/patman -n' will check your patch and find these problems. Regards, Simon
diff --git a/tools/mkimage.c b/tools/mkimage.c index 7f22101..08aa634 100644 --- a/tools/mkimage.c +++ b/tools/mkimage.c @@ -632,8 +632,8 @@ copy_file (int ifd, const char *datafile, int pad) (void) close (dfd); } -void -usage () +static void +usage (void) { fprintf (stderr, "Usage: %s -l image\n" " -l ==> list image header information\n",