Patchwork [V2] ahci: Changing two module params with static and __read_mostly

login
register
mail settings
Submitter Chuansheng Liu
Date Sept. 18, 2013, 12:21 p.m.
Message ID <1379506909.26153.33.camel@cliu38-desktop-build>
Download mbox | patch
Permalink /patch/275579/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Chuansheng Liu - Sept. 18, 2013, 12:21 p.m.
Here module parameters ahci_em_messages and devslp_idle_timeout can
be set as static and __read_mostly.

Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com>
---
 drivers/ata/libahci.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Tejun Heo - Sept. 22, 2013, 4:54 p.m.
On Wed, Sep 18, 2013 at 08:21:49PM +0800, Chuansheng Liu wrote:
> 
> Here module parameters ahci_em_messages and devslp_idle_timeout can
> be set as static and __read_mostly.
> 
> Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com>

Applied to libata/for-3.13.  Thanks.

Patch

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index acfd0f7..b67086f 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -189,14 +189,15 @@  struct ata_port_operations ahci_pmp_retry_srst_ops = {
 };
 EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops);
 
-int ahci_em_messages = 1;
+static bool ahci_em_messages __read_mostly = true;
 EXPORT_SYMBOL_GPL(ahci_em_messages);
-module_param(ahci_em_messages, int, 0444);
+module_param(ahci_em_messages, bool, 0444);
 /* add other LED protocol types when they become supported */
 MODULE_PARM_DESC(ahci_em_messages,
 	"AHCI Enclosure Management Message control (0 = off, 1 = on)");
 
-int devslp_idle_timeout = 1000;	/* device sleep idle timeout in ms */
+/* device sleep idle timeout in ms */
+static int devslp_idle_timeout __read_mostly = 1000;
 module_param(devslp_idle_timeout, int, 0644);
 MODULE_PARM_DESC(devslp_idle_timeout, "device sleep idle timeout");