From patchwork Tue Sep 17 17:30:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: boxi liu X-Patchwork-Id: 275511 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4DC112C00D9 for ; Wed, 18 Sep 2013 03:30:38 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753297Ab3IQRah (ORCPT ); Tue, 17 Sep 2013 13:30:37 -0400 Received: from mail-ie0-f179.google.com ([209.85.223.179]:65532 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753007Ab3IQRag convert rfc822-to-8bit (ORCPT ); Tue, 17 Sep 2013 13:30:36 -0400 Received: by mail-ie0-f179.google.com with SMTP id e14so11043309iej.10 for ; Tue, 17 Sep 2013 10:30:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=595vAH/T5ldiZw7eKN9hxWma28kAdLd5kovBP5WoOI4=; b=qRkCk70+Di2hi2PmqdTVaogURV849RajrbNiW/HfDGsJ4kl20+WmIuzA+fygBx82O6 NjL3m3Qk7TTuuMZgwS6bY+XkBdYHY+aRtnS32B/EaK5N56rDLsbvcCPcrLc5bRicqkxb 47s4ftN1zmc/FthYD/GIPRbTFGJa2yIPa/a5mICcdWj8wpLlNs2NYX/Cl6fl89IQm7Ld c/0fDltlCfc7YkjLQdg9gRsi5Zq+oKb08ZIZofU9VeqtFAWdaIiepqP5JGl8cbkwiCnJ piFtOHuNxKJBqj+ouKFcL7Y4Nf3oEaSZbEFQAPdr2bARPpbvuyzuXb5qH7UdmM+z/jEN wBUA== MIME-Version: 1.0 X-Received: by 10.50.136.135 with SMTP id qa7mr1446407igb.49.1379439036364; Tue, 17 Sep 2013 10:30:36 -0700 (PDT) Received: by 10.64.128.233 with HTTP; Tue, 17 Sep 2013 10:30:36 -0700 (PDT) In-Reply-To: <20130917162916.GA16938@quack.suse.cz> References: <20130917162916.GA16938@quack.suse.cz> Date: Wed, 18 Sep 2013 01:30:36 +0800 Message-ID: Subject: Re: fix the ext4_read_inline_dir return value From: Boxi Liu To: Jan Kara Cc: "linux-ext4@vger.kernel.org" , Theodore Tso , Robin Dong , "tm@tao.ma" , "lewis.liulei" , pamirs Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Thanks to point the that,I will fix it. ext4: fix the ext4_read_inline_dir return value In ext4_read_inlne_dir,the return value is the return of ext4_read_inline_data len.But in no inline_data case, the return value is 0,it's inconsistent.So fix the return value of ext4_read_inline_dir. Signed-off-by: BoxiLiu --- fs/ext4/inline.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index d9ecbf1..c3efb65 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -1442,6 +1442,7 @@ int ext4_read_inline_dir(struct file *file, if (ret < 0) goto out; + ret = 0; sb = inode->i_sb; parent_ino = le32_to_cpu(((struct ext4_dir_entry_2 *)dir_buf)->inode); offset = ctx->pos;