Patchwork [U-Boot,08/10] arm: vf610: add rmii1 iomux definitions

login
register
mail settings
Submitter Marcel Ziswiler
Date Sept. 17, 2013, 10:45 a.m.
Message ID <506d44ccbca30b129e15ad423cade2b4ad5f84a9.1379414181.git.marcel@ziswiler.com>
Download mbox | patch
Permalink /patch/275434/
State Superseded
Delegated to: Albert ARIBAUD
Headers show

Comments

Marcel Ziswiler - Sept. 17, 2013, 10:45 a.m.
Add secondary RMII1 iomux definitions.

Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
---
 arch/arm/include/asm/arch-vf610/iomux-vf610.h |    9 +++++++++
 1 file changed, 9 insertions(+)
Alison Wang - Sept. 22, 2013, 5:56 a.m.
> -----Original Message-----
> From: Marcel Ziswiler [mailto:marcel@ziswiler.com]
> Sent: Tuesday, September 17, 2013 6:45 PM
> To: u-boot@lists.denx.de
> Cc: Wang Huan-B18965; Marcel Ziswiler
> Subject: [PATCH 08/10] arm: vf610: add rmii1 iomux definitions
> 
> Add secondary RMII1 iomux definitions.
> 
> Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
> ---
>  arch/arm/include/asm/arch-vf610/iomux-vf610.h |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-vf610/iomux-vf610.h
> b/arch/arm/include/asm/arch-vf610/iomux-vf610.h
> index a6f7132..1b410c3 100644
> --- a/arch/arm/include/asm/arch-vf610/iomux-vf610.h
> +++ b/arch/arm/include/asm/arch-vf610/iomux-vf610.h
> @@ -36,6 +36,15 @@ enum {
>  	VF610_PAD_PTC6__RMII0_TD1		= IOMUX_PAD(0x00cc, 0x00cc, 1,
> __NA_, 0, VF610_ENET_PAD_CTRL),
>  	VF610_PAD_PTC7__RMII0_TD0		= IOMUX_PAD(0x00D0, 0x00D0, 1,
> __NA_, 0, VF610_ENET_PAD_CTRL),
>  	VF610_PAD_PTC8__RMII0_TXEN		= IOMUX_PAD(0x00D4, 0x00D4, 1,
> __NA_, 0, VF610_ENET_PAD_CTRL),
> +	VF610_PAD_PTC10__RMII1_MDIO		= IOMUX_PAD(0x00dc, 0x00b8, 1,
> __NA_, 0, VF610_ENET_PAD_CTRL),
> +	VF610_PAD_PTC9__RMII1_MDC		= IOMUX_PAD(0x00d8, 0x00b4, 1,
> __NA_, 0, VF610_ENET_PAD_CTRL),
> +	VF610_PAD_PTC11__RMII1_CRS_DV		= IOMUX_PAD(0x00e0, 0x00bc, 1,
> __NA_, 0, VF610_ENET_PAD_CTRL),
> +	VF610_PAD_PTC12__RMII1_RD1		= IOMUX_PAD(0x00e4, 0x00c0, 1,
> __NA_, 0, VF610_ENET_PAD_CTRL),
> +	VF610_PAD_PTC13__RMII1_RD0		= IOMUX_PAD(0x00e8, 0x00c4, 1,
> __NA_, 0, VF610_ENET_PAD_CTRL),
> +	VF610_PAD_PTC14__RMII1_RXER		= IOMUX_PAD(0x00ec, 0x00c8, 1,
> __NA_, 0, VF610_ENET_PAD_CTRL),
> +	VF610_PAD_PTC15__RMII1_TD1		= IOMUX_PAD(0x00f0, 0x00cc, 1,
> __NA_, 0, VF610_ENET_PAD_CTRL),
> +	VF610_PAD_PTC16__RMII1_TD0		= IOMUX_PAD(0x00f4, 0x00D0, 1,
> __NA_, 0, VF610_ENET_PAD_CTRL),
> +	VF610_PAD_PTC17__RMII1_TXEN		= IOMUX_PAD(0x00f8, 0x00D4, 1,
> __NA_, 0, VF610_ENET_PAD_CTRL),
>  	VF610_PAD_PTA24__ESDHC1_CLK		= IOMUX_PAD(0x0038, 0x0038, 5,
> __NA_, 0, VF610_SDHC_PAD_CTRL),
>  	VF610_PAD_PTA25__ESDHC1_CMD		= IOMUX_PAD(0x003c, 0x003c, 5,
> __NA_, 0, VF610_SDHC_PAD_CTRL),
>  	VF610_PAD_PTA26__ESDHC1_DAT0		= IOMUX_PAD(0x0040, 0x0040, 5,
> __NA_, 0, VF610_SDHC_PAD_CTRL),
[Alison Wang] For these RMII1 IOMUX definitions, the mux_ctrl_ofs parameter should be the same as pad_ctrL_ofs parameter. In this patch, the mux_ctrl_ofs are all for RMII0.


Best Regards,
Alison Wang
Marcel Ziswiler - Sept. 30, 2013, 8:24 a.m.
On 09/22/2013 07:56 AM, Wang Huan-B18965 wrote:
>> -----Original Message-----
>> From: Marcel Ziswiler [mailto:marcel@ziswiler.com]
>> Sent: Tuesday, September 17, 2013 6:45 PM
>> To: u-boot@lists.denx.de
>> Cc: Wang Huan-B18965; Marcel Ziswiler
>> Subject: [PATCH 08/10] arm: vf610: add rmii1 iomux definitions
>>
>> Add secondary RMII1 iomux definitions.
>>
>> Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
>> ---
>>   arch/arm/include/asm/arch-vf610/iomux-vf610.h |    9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-vf610/iomux-vf610.h
>> b/arch/arm/include/asm/arch-vf610/iomux-vf610.h
>> index a6f7132..1b410c3 100644
>> --- a/arch/arm/include/asm/arch-vf610/iomux-vf610.h
>> +++ b/arch/arm/include/asm/arch-vf610/iomux-vf610.h
>> @@ -36,6 +36,15 @@ enum {
>>   	VF610_PAD_PTC6__RMII0_TD1		= IOMUX_PAD(0x00cc, 0x00cc, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>>   	VF610_PAD_PTC7__RMII0_TD0		= IOMUX_PAD(0x00D0, 0x00D0, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>>   	VF610_PAD_PTC8__RMII0_TXEN		= IOMUX_PAD(0x00D4, 0x00D4, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC10__RMII1_MDIO		= IOMUX_PAD(0x00dc, 0x00b8, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC9__RMII1_MDC		= IOMUX_PAD(0x00d8, 0x00b4, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC11__RMII1_CRS_DV		= IOMUX_PAD(0x00e0, 0x00bc, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC12__RMII1_RD1		= IOMUX_PAD(0x00e4, 0x00c0, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC13__RMII1_RD0		= IOMUX_PAD(0x00e8, 0x00c4, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC14__RMII1_RXER		= IOMUX_PAD(0x00ec, 0x00c8, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC15__RMII1_TD1		= IOMUX_PAD(0x00f0, 0x00cc, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC16__RMII1_TD0		= IOMUX_PAD(0x00f4, 0x00D0, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC17__RMII1_TXEN		= IOMUX_PAD(0x00f8, 0x00D4, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>>   	VF610_PAD_PTA24__ESDHC1_CLK		= IOMUX_PAD(0x0038, 0x0038, 5,
>> __NA_, 0, VF610_SDHC_PAD_CTRL),
>>   	VF610_PAD_PTA25__ESDHC1_CMD		= IOMUX_PAD(0x003c, 0x003c, 5,
>> __NA_, 0, VF610_SDHC_PAD_CTRL),
>>   	VF610_PAD_PTA26__ESDHC1_DAT0		= IOMUX_PAD(0x0040, 0x0040, 5,
>> __NA_, 0, VF610_SDHC_PAD_CTRL),
> [Alison Wang] For these RMII1 IOMUX definitions, the mux_ctrl_ofs parameter should be the same as pad_ctrL_ofs parameter. In this patch, the mux_ctrl_ofs are all for RMII0.
Yes, you are absolutely right. How could I have missed that one - stupid 
me. Strange that it actually worked at all.

I will cook up a new patch series shortly.

Patch

diff --git a/arch/arm/include/asm/arch-vf610/iomux-vf610.h b/arch/arm/include/asm/arch-vf610/iomux-vf610.h
index a6f7132..1b410c3 100644
--- a/arch/arm/include/asm/arch-vf610/iomux-vf610.h
+++ b/arch/arm/include/asm/arch-vf610/iomux-vf610.h
@@ -36,6 +36,15 @@  enum {
 	VF610_PAD_PTC6__RMII0_TD1		= IOMUX_PAD(0x00cc, 0x00cc, 1, __NA_, 0, VF610_ENET_PAD_CTRL),
 	VF610_PAD_PTC7__RMII0_TD0		= IOMUX_PAD(0x00D0, 0x00D0, 1, __NA_, 0, VF610_ENET_PAD_CTRL),
 	VF610_PAD_PTC8__RMII0_TXEN		= IOMUX_PAD(0x00D4, 0x00D4, 1, __NA_, 0, VF610_ENET_PAD_CTRL),
+	VF610_PAD_PTC10__RMII1_MDIO		= IOMUX_PAD(0x00dc, 0x00b8, 1, __NA_, 0, VF610_ENET_PAD_CTRL),
+	VF610_PAD_PTC9__RMII1_MDC		= IOMUX_PAD(0x00d8, 0x00b4, 1, __NA_, 0, VF610_ENET_PAD_CTRL),
+	VF610_PAD_PTC11__RMII1_CRS_DV		= IOMUX_PAD(0x00e0, 0x00bc, 1, __NA_, 0, VF610_ENET_PAD_CTRL),
+	VF610_PAD_PTC12__RMII1_RD1		= IOMUX_PAD(0x00e4, 0x00c0, 1, __NA_, 0, VF610_ENET_PAD_CTRL),
+	VF610_PAD_PTC13__RMII1_RD0		= IOMUX_PAD(0x00e8, 0x00c4, 1, __NA_, 0, VF610_ENET_PAD_CTRL),
+	VF610_PAD_PTC14__RMII1_RXER		= IOMUX_PAD(0x00ec, 0x00c8, 1, __NA_, 0, VF610_ENET_PAD_CTRL),
+	VF610_PAD_PTC15__RMII1_TD1		= IOMUX_PAD(0x00f0, 0x00cc, 1, __NA_, 0, VF610_ENET_PAD_CTRL),
+	VF610_PAD_PTC16__RMII1_TD0		= IOMUX_PAD(0x00f4, 0x00D0, 1, __NA_, 0, VF610_ENET_PAD_CTRL),
+	VF610_PAD_PTC17__RMII1_TXEN		= IOMUX_PAD(0x00f8, 0x00D4, 1, __NA_, 0, VF610_ENET_PAD_CTRL),
 	VF610_PAD_PTA24__ESDHC1_CLK		= IOMUX_PAD(0x0038, 0x0038, 5, __NA_, 0, VF610_SDHC_PAD_CTRL),
 	VF610_PAD_PTA25__ESDHC1_CMD		= IOMUX_PAD(0x003c, 0x003c, 5, __NA_, 0, VF610_SDHC_PAD_CTRL),
 	VF610_PAD_PTA26__ESDHC1_DAT0		= IOMUX_PAD(0x0040, 0x0040, 5, __NA_, 0, VF610_SDHC_PAD_CTRL),