Patchwork RFC - Refactor tree.h

login
register
mail settings
Submitter Diego Novillo
Date Sept. 16, 2013, 1:39 p.m.
Message ID <CAD_=9DTFhR48D-Evt+i97ZNSn2JNBhU6TOMRp8+Pf-wJZJi01w@mail.gmail.com>
Download mbox | patch
Permalink /patch/275217/
State New
Headers show

Comments

Diego Novillo - Sept. 16, 2013, 1:39 p.m.
On Fri, Sep 13, 2013 at 11:25 AM, Diego Novillo <dnovillo@google.com> wrote:
> On Fri, Sep 13, 2013 at 11:07 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>
>> E.g. today I've noticed you've lost OMP_CLAUSE_LINEAR_NO_COPYIN
>> comment that has been added to tree.h recently, but you haven't
>> actually moved it into tree-core.h.
>
> Sorry about that.  I remember an update conflict, but I thought I had
> incorporated it all.  I will double check and fix.


Done.

 gcc/ChangeLog   |  5 +++++
 gcc/tree-core.h | 19 +++++++++++++++++--
 2 files changed, 22 insertions(+), 2 deletions(-)

--
1.8.4
Jakub Jelinek - Sept. 16, 2013, 1:42 p.m.
On Mon, Sep 16, 2013 at 09:39:27AM -0400, Diego Novillo wrote:
> On Fri, Sep 13, 2013 at 11:25 AM, Diego Novillo <dnovillo@google.com> wrote:
> > On Fri, Sep 13, 2013 at 11:07 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> >
> >> E.g. today I've noticed you've lost OMP_CLAUSE_LINEAR_NO_COPYIN
> >> comment that has been added to tree.h recently, but you haven't
> >> actually moved it into tree-core.h.
> >
> > Sorry about that.  I remember an update conflict, but I thought I had
> > incorporated it all.  I will double check and fix.
> 
> 
> Done.

Thanks.

	Jakub

Patch

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index b9a335a..906d01b 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@ 
+2013-09-16  Diego Novillo  <dnovillo@google.com>
+
+       * tree-core.h: Add missing comment lines from refactoring
+       of tree.h.
+
 2013-09-16  Jan Hubicka  <jh@suse.cz>

        * gimple-fold.c (can_refer_decl_in_current_unit_p): Do not accept
diff --git a/gcc/tree-core.h b/gcc/tree-core.h
index b1bc56a..69777dc 100644
--- a/gcc/tree-core.h
+++ b/gcc/tree-core.h
@@ -780,6 +780,9 @@  struct GTY(()) tree_base {
        OMP_CLAUSE_PRIVATE_DEBUG in
            OMP_CLAUSE_PRIVATE

+       OMP_CLAUSE_LINEAR_NO_COPYIN in
+          OMP_CLAUSE_LINEAR
+
        TRANSACTION_EXPR_RELAXED in
           TRANSACTION_EXPR

@@ -800,6 +803,9 @@  struct GTY(()) tree_base {
        OMP_CLAUSE_PRIVATE_OUTER_REF in
           OMP_CLAUSE_PRIVATE

+       OMP_CLAUSE_LINEAR_NO_COPYOUT in
+          OMP_CLAUSE_LINEAR
+
        TYPE_REF_IS_RVALUE in
           REFERENCE_TYPE

@@ -935,6 +941,9 @@  struct GTY(()) tree_base {

        DECL_NONLOCAL_FRAME in
           VAR_DECL
+
+       TYPE_FINAL_P in
+          RECORD_TYPE, UNION_TYPE and QUAL_UNION_TYPE
 */

 struct GTY(()) tree_typed {
@@ -1197,8 +1206,7 @@  struct GTY(()) tree_decl_common {
   unsigned lang_flag_7 : 1;
   unsigned lang_flag_8 : 1;

-  /* In LABEL_DECL, this is DECL_ERROR_ISSUED.
-     In VAR_DECL and PARM_DECL, this is DECL_REGISTER.  */
+  /* In VAR_DECL and PARM_DECL, this is DECL_REGISTER.  */
   unsigned decl_flag_0 : 1;
   /* In FIELD_DECL, this is DECL_BIT_FIELD
      In VAR_DECL and FUNCTION_DECL, this is DECL_EXTERNAL.
@@ -1403,6 +1411,9 @@  struct GTY(()) tree_statement_list
   struct tree_statement_list_node *tail;
 };

+
+/* Optimization options used by a function.  */
+
 struct GTY(()) tree_optimization_option {
   struct tree_common common;

@@ -1418,6 +1429,8 @@  struct GTY(()) tree_optimization_option {
   struct target_optabs *GTY ((skip)) base_optabs;
 };

+/* Target options used by a function.  */
+
 struct GTY(()) tree_target_option {
   struct tree_common common;

@@ -1563,6 +1576,8 @@  struct GTY(()) tree_map_base {
   tree from;
 };

+/* Map from a tree to another tree.  */
+
 struct GTY(()) tree_map {
   struct tree_map_base base;
   unsigned int hash;