From patchwork Mon Sep 16 08:25:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Ottlik X-Patchwork-Id: 275144 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BC8D82C00E2 for ; Mon, 16 Sep 2013 18:26:23 +1000 (EST) Received: from localhost ([::1]:60558 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLU8T-0003DP-4Z for incoming@patchwork.ozlabs.org; Mon, 16 Sep 2013 04:26:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLU7a-0003By-6Q for qemu-devel@nongnu.org; Mon, 16 Sep 2013 04:25:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLU7T-0004wR-Qt for qemu-devel@nongnu.org; Mon, 16 Sep 2013 04:25:26 -0400 Received: from ex-e-2.perimeter.fzi.de ([141.21.8.251]:53557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLU7T-0004w8-L6 for qemu-devel@nongnu.org; Mon, 16 Sep 2013 04:25:19 -0400 Received: from ex-ca-ht-1.fzi.de (141.21.32.98) by ex-e-2.perimeter.fzi.de (141.21.8.251) with Microsoft SMTP Server (TLS) id 14.3.158.1; Mon, 16 Sep 2013 10:25:08 +0200 Received: from orcrist.fzi.de (2a02:788:13:20:f96a:dcf7:d77a:f817) by ex-ca-ht-1.fzi.de (2a02:788:13:20::8d15:2062) with Microsoft SMTP Server id 14.3.158.1; Mon, 16 Sep 2013 10:25:12 +0200 Received: by orcrist.fzi.de (Postfix, from userid 330838105) id 4262E1C066D; Mon, 16 Sep 2013 10:25:12 +0200 (CEST) From: Sebastian Ottlik To: Date: Mon, 16 Sep 2013 10:25:04 +0200 Message-ID: <1379319907-14950-3-git-send-email-ottlik@fzi.de> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1379319907-14950-1-git-send-email-ottlik@fzi.de> References: <1379319907-14950-1-git-send-email-ottlik@fzi.de> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 141.21.8.251 Cc: Jan Kiszka , Anthony Liguori , Sebastian Ottlik , Stefan Hajnoczi Subject: [Qemu-devel] [PATCH v4 2/5] gdbstub: call socket_set_fast_reuse instead of setting SO_REUSEADDR X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik --- gdbstub.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 2b7f22b..f43291a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1553,7 +1553,7 @@ static void gdb_accept(void) static int gdbserver_open(int port) { struct sockaddr_in sockaddr; - int fd, val, ret; + int fd, ret; fd = socket(PF_INET, SOCK_STREAM, 0); if (fd < 0) { @@ -1564,9 +1564,7 @@ static int gdbserver_open(int port) fcntl(fd, F_SETFD, FD_CLOEXEC); #endif - /* allow fast reuse */ - val = 1; - qemu_setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &val, sizeof(val)); + socket_set_fast_reuse(fd, false); sockaddr.sin_family = AF_INET; sockaddr.sin_port = htons(port);