From patchwork Thu May 21 20:17:44 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mika Korhonen X-Patchwork-Id: 27514 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id 179CFB6F34 for ; Fri, 22 May 2009 16:06:45 +1000 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1M7Npu-0007po-Fo; Fri, 22 May 2009 06:02:30 +0000 Received: from ey-out-1920.google.com ([74.125.78.148]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1M7Ei3-0003xd-8v for linux-mtd@lists.infradead.org; Thu, 21 May 2009 20:17:54 +0000 Received: by ey-out-1920.google.com with SMTP id 13so287058eye.24 for ; Thu, 21 May 2009 13:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:cc:content-type; bh=jDAr/NudIZvRItSs9yrrnd5TgLhb1di2nUya8u+e4aw=; b=faBT7rKsJqxGtLkWY9ocn2saJcjh/4OkmrsBrYxviCqGb8qPPK99pZBPtRj6+o/kHp QJ7nXqtHZ2wNJidePlvx8PIWx0hdYZjIVohrSwC1FJSqDYuMhHrSI6t99BNPInVttc5O qeknx9Kt1evjLbSgUf9ML11G+UWWCa4CWAsBg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; b=smb9O9Lzd6oTFsEuRvYxlo9GxSrd5ze2mO6dQyGtuhLh54srq6tDF3Xm9urO/WsS6+ 0eNQk+jMbmf76t7HCPikkmxzAQ4S/HqW/c+MMx3eH6C7BCGroluZJIU+LGcT5bF0Hx5D sNky1sjx51EmpTsg8zk7u4/AUKwKFWaRBv56k= MIME-Version: 1.0 Received: by 10.216.47.204 with SMTP id t54mr591638web.75.1242937064830; Thu, 21 May 2009 13:17:44 -0700 (PDT) Date: Thu, 21 May 2009 23:17:44 +0300 Message-ID: <7948530905211317h5bd9a395ta5b8575befed96c@mail.gmail.com> Subject: [PATCH] [MTD] ONENAND: Fix devexit macro usage in OMAP OneNAND (was Re: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers) From: Mika Korhonen To: David Brownell X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Fri, 22 May 2009 02:02:29 -0400 Cc: linux-mtd Mailing List , David Woodhouse , Adrian Hunter X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org 2009/4/29 David Brownell : > On Wednesday 29 April 2009, Adrian Hunter wrote: >> +       .shutdown       = __devexit_p(omap2_onenand_shutdown), > > That looks wrong.  Shutdown functions shouldn't get discarded > like exit functions.  I'd think the fix for that would be taking > away any __devexit annotation on the shutdown function. > > Here follows the revised patch, fixed as suggested. Mika From 090161dcc28f685a9b1f15c2c652925f052bdf18 Mon Sep 17 00:00:00 2001 From: Mika Korhonen Date: Thu, 21 May 2009 23:09:42 +0300 Subject: [PATCH] Fix devexit macro usage in OMAP OneNAND Add missing __devexit_p wrapper and no more mark shutdown with __devesit. Fixes build in configurations where devexit functions get discarded. Signed-off-by: Mika Korhonen --- drivers/mtd/onenand/omap2.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c index f2e9de1..df26db8 100644 --- a/drivers/mtd/onenand/omap2.c +++ b/drivers/mtd/onenand/omap2.c @@ -566,7 +566,7 @@ int omap2_onenand_rephase(void) NULL, __adjust_timing); } -static void __devexit omap2_onenand_shutdown(struct platform_device *pdev) +static void omap2_onenand_shutdown(struct platform_device *pdev) { struct omap2_onenand *c = dev_get_drvdata(&pdev->dev); @@ -778,7 +778,7 @@ static int __devexit omap2_onenand_remove(struct platform_device *pdev) static struct platform_driver omap2_onenand_driver = { .probe = omap2_onenand_probe, - .remove = omap2_onenand_remove, + .remove = __devexit_p(omap2_onenand_remove), .shutdown = omap2_onenand_shutdown, .driver = { .name = DRIVER_NAME, -- 1.6.0.4