| Message ID | 1379297509-8641-1-git-send-email-festevam@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
Dear Fabio Estevam, > From: Fabio Estevam <fabio.estevam@freescale.com> > > Since commit bce883707 (ARM: mxs: tools: Add mkimage support for MXS > bootstream) the following build error is seen when doing a MAKEALL build: > > $ ./MAKEALL mx28evk > Configuring for mx28evk - Board: mx28evk, Options: ENV_IS_IN_MMC > mxsimage.c:18:25: fatal error: openssl/evp.h: No such file or directory > > Add an entry about the need of installing the 'libssl-dev' package. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > Changes since v1: > - Do not remove the 'elftosb' text. > > doc/README.mxs | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/doc/README.mxs b/doc/README.mxs > index 5d9e72f..1e5bc5c 100644 > --- a/doc/README.mxs > +++ b/doc/README.mxs > @@ -63,6 +63,11 @@ copy the binary by hand: > Make sure the "elftosb" binary can be found in your $PATH, in this case > this means "/usr/local/bin/" has to be in your $PATH. > > +Install the 'libssl-dev' package as well. On a Ubuntu-based distribution, > this +package can be installed as follows: > + > + $ sudo apt-get install libssl-dev > + Since when is Ubuntu not a Debian based distro ? :-( I think you should stick with the roots here, use Debian. > 2) Compiling U-Boot for a MXS based board > ------------------------------------------- Best regards, Marek Vasut
On Mon, Sep 16, 2013 at 10:49 AM, Marek Vasut <marex@denx.de> wrote: > Since when is Ubuntu not a Debian based distro ? :-( I think you should stick > with the roots here, use Debian. Yes, I wrote "Debian-based" in v1. The change here was not on purpose, so I can fix it in v3. Actually, I have been thinking about this fix: wouldn't it be better to copy the 'openssl/evp.h' header into U-boot tool directory to avoid people getting failures with MAKEALL if they do not have libssl-dev installed?
Dear Fabio Estevam, > On Mon, Sep 16, 2013 at 10:49 AM, Marek Vasut <marex@denx.de> wrote: > > Since when is Ubuntu not a Debian based distro ? :-( I think you should > > stick with the roots here, use Debian. > > Yes, I wrote "Debian-based" in v1. The change here was not on purpose, > so I can fix it in v3. > > Actually, I have been thinking about this fix: wouldn't it be better > to copy the 'openssl/evp.h' header into U-boot tool directory to avoid > people getting failures with MAKEALL if they do not have libssl-dev > installed? No, because they won't be able to link without the dev package anyway. Best regards, Marek Vasut
On 16/09/2013 16:19, Fabio Estevam wrote: > On Mon, Sep 16, 2013 at 10:49 AM, Marek Vasut <marex@denx.de> wrote: > >> Since when is Ubuntu not a Debian based distro ? :-( I think you should stick >> with the roots here, use Debian. > > Yes, I wrote "Debian-based" in v1. The change here was not on purpose, > so I can fix it in v3. > > Actually, I have been thinking about this fix: wouldn't it be better > to copy the 'openssl/evp.h' header into U-boot tool directory to avoid > people getting failures with MAKEALL if they do not have libssl-dev > installed? > I disagree : it is not different if another include file is missing, or the host is not installed. Then the hint is to install build-essential (Ubuntu) or all packages, not to move them inside u-boot. Regards, Stefano
Dear Stefano Babic, > On 16/09/2013 16:19, Fabio Estevam wrote: > > On Mon, Sep 16, 2013 at 10:49 AM, Marek Vasut <marex@denx.de> wrote: > >> Since when is Ubuntu not a Debian based distro ? :-( I think you should > >> stick with the roots here, use Debian. > > > > Yes, I wrote "Debian-based" in v1. The change here was not on purpose, > > so I can fix it in v3. > > > > Actually, I have been thinking about this fix: wouldn't it be better > > to copy the 'openssl/evp.h' header into U-boot tool directory to avoid > > people getting failures with MAKEALL if they do not have libssl-dev > > installed? > > I disagree : it is not different if another include file is missing, or > the host is not installed. Then the hint is to install build-essential > (Ubuntu) or all packages, not to move them inside u-boot. Hey, build-essential is also Debian (lol) ! ;-) Best regards, Marek Vasut
On Mon, Sep 16, 2013 at 12:55 PM, Marek Vasut <marex@denx.de> wrote: > Dear Stefano Babic, > >> On 16/09/2013 16:19, Fabio Estevam wrote: >> > On Mon, Sep 16, 2013 at 10:49 AM, Marek Vasut <marex@denx.de> wrote: >> >> Since when is Ubuntu not a Debian based distro ? :-( I think you should >> >> stick with the roots here, use Debian. >> > >> > Yes, I wrote "Debian-based" in v1. The change here was not on purpose, >> > so I can fix it in v3. >> > >> > Actually, I have been thinking about this fix: wouldn't it be better >> > to copy the 'openssl/evp.h' header into U-boot tool directory to avoid >> > people getting failures with MAKEALL if they do not have libssl-dev >> > installed? >> >> I disagree : it is not different if another include file is missing, or >> the host is not installed. Then the hint is to install build-essential >> (Ubuntu) or all packages, not to move them inside u-boot. > > Hey, build-essential is also Debian (lol) ! ;-) Debian +1 :-)
diff --git a/doc/README.mxs b/doc/README.mxs index 5d9e72f..1e5bc5c 100644 --- a/doc/README.mxs +++ b/doc/README.mxs @@ -63,6 +63,11 @@ copy the binary by hand: Make sure the "elftosb" binary can be found in your $PATH, in this case this means "/usr/local/bin/" has to be in your $PATH. +Install the 'libssl-dev' package as well. On a Ubuntu-based distribution, this +package can be installed as follows: + + $ sudo apt-get install libssl-dev + 2) Compiling U-Boot for a MXS based board -------------------------------------------