Patchwork [U-Boot,v2] gpio: spear_gpio: Fix gpio_set_value() implementation

mail settings
Submitter Axel Lin
Date Sept. 16, 2013, 12:35 a.m.
Message ID <1379291741.13052.1.camel@phoenix>
Download mbox | patch
Permalink /patch/275087/
State New
Delegated to: Vipin Kumar
Headers show


Axel Lin - Sept. 16, 2013, 12:35 a.m.
In current gpio_set_value() implementation, it always sets the gpio control bit
no matter the value argument is 0 or 1. Thus the GPIOs never set to low.
This patch fixes this bug.

The address bus is used as a mask on read/write operations, so that independent
software drivers can set their GPIO bits without affecting any other pins in a
single write operation. Thus we don't need a read-modify-write to update the

Signed-off-by: Axel Lin <>
Acked-by: Stefan Roese <>
Reviewed-by: Vipin Kumar <>
Reviewed-by: Michael Trimarchi <>
v2: Update commit log to explain why a read-modify-write is not necessary
    for clearing specific GPIO bit.
    Also added Michael Trimarchi's reviewed-by tag since he does review the
    patch and said the patch is fine.

 drivers/gpio/spear_gpio.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


diff --git a/drivers/gpio/spear_gpio.c b/drivers/gpio/spear_gpio.c
index 367b670..6fb4117 100644
--- a/drivers/gpio/spear_gpio.c
+++ b/drivers/gpio/spear_gpio.c
@@ -36,7 +36,10 @@  int gpio_set_value(unsigned gpio, int value)
 	struct gpio_regs *regs = (struct gpio_regs *)CONFIG_GPIO_BASE;
-	writel(1 << gpio, &regs->gpiodata[DATA_REG_ADDR(gpio)]);
+	if (value)
+		writel(1 << gpio, &regs->gpiodata[DATA_REG_ADDR(gpio)]);
+	else
+		writel(0, &regs->gpiodata[DATA_REG_ADDR(gpio)]);
 	return 0;