From patchwork Thu May 21 21:59:15 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: 2.6.29.1 pktgen crash Date: Thu, 21 May 2009 11:59:15 -0000 From: Florian Westphal X-Patchwork-Id: 27508 Message-Id: <20090521215915.GA32737@Chamillionaire.breakpoint.cc> To: Vladimir Ivashchenko Cc: netdev@vger.kernel.org Vladimir Ivashchenko wrote: > The attached script leads to a crash when you run it for 2-3 times on 2.6.29.1. The server still remains reachable, but starts misbehaving. > > May 20 21:09:03 tshape-phome2 kernel: BUG: unable to handle kernel paging request at f8bbc008 > May 20 21:09:03 tshape-phome2 kernel: IP: [] pktgen_remove_device+0x88/0xdc [pktgen] > May 20 21:09:03 tshape-phome2 kernel: *pde = 31030067 *pte = 00000000 > May 20 21:09:03 tshape-phome2 kernel: Oops: 0000 [#1] SMP [..] This should fix it: >From bca277bb59b865a4e9516953dfc9818af1a7deea Mon Sep 17 00:00:00 2001 From: Florian Westphal Date: Thu, 21 May 2009 23:52:17 +0200 Subject: [PATCH] pktgen: do not access flows[] beyond its length typo -- pkt_dev->nflows is for stats only, the number of concurrent flows is stored in cflows. Reported-By: Vladimir Ivashchenko Signed-off-by: Florian Westphal --- net/core/pktgen.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 3779c14..8445075 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -2447,7 +2447,7 @@ static inline void free_SAs(struct pktgen_dev *pkt_dev) if (pkt_dev->cflows) { /* let go of the SAs if we have them */ int i = 0; - for (; i < pkt_dev->nflows; i++){ + for (; i < pkt_dev->cflows; i++) { struct xfrm_state *x = pkt_dev->flows[i].x; if (x) { xfrm_state_put(x);