Patchwork sunlance: beyond ARRAY_SIZE of ib->btx_ring

login
register
mail settings
Submitter roel kluin
Date May 21, 2009, 8:31 p.m.
Message ID <4A15BA10.7080605@gmail.com>
Download mbox | patch
Permalink /patch/27500/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

roel kluin - May 21, 2009, 8:31 p.m.
Do not go beyond ARRAY_SIZE of ib->btx_ring

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Please ignore the other "X: ... patch"

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - May 21, 2009, 8:34 p.m.
From: Roel Kluin <roel.kluin@gmail.com>
Date: Thu, 21 May 2009 22:31:12 +0200

> Do not go beyond ARRAY_SIZE of ib->btx_ring
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Please ignore the other "X: ... patch"

You don't need to keep CC:'ing Jeff, he hasn't handled networking
device driver patches for some time now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - May 21, 2009, 10:02 p.m.
From: Roel Kluin <roel.kluin@gmail.com>
Date: Thu, 21 May 2009 22:31:12 +0200

> Do not go beyond ARRAY_SIZE of ib->btx_ring
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

What in the world are you generating this patch against?

Linus's tree already has this change, for months.

And it was added by you, in February!

commit b956d41162b1f2c4b446107e9910e4719cbc75f4
Author: Roel Kluin <roel.kluin@gmail.com>
Date:   Sat Feb 21 23:46:36 2009 -0800

    sunlance: Beyond ARRAY_SIZE of ib->btx_ring
    
    Do not go beyond ARRAY_SIZE of ib->btx_ring
    
    Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/sunlance.c b/drivers/net/sunlance.c
index 704301a..e7f1178 100644
--- a/drivers/net/sunlance.c
+++ b/drivers/net/sunlance.c
@@ -343,7 +343,7 @@  static void lance_init_ring_dvma(struct net_device *dev)
 	ib->phys_addr [5] = dev->dev_addr [4];
 
 	/* Setup the Tx ring entries */
-	for (i = 0; i <= TX_RING_SIZE; i++) {
+	for (i = 0; i < TX_RING_SIZE; i++) {
 		leptr = LANCE_ADDR(aib + libbuff_offset(tx_buf, i));
 		ib->btx_ring [i].tmd0      = leptr;
 		ib->btx_ring [i].tmd1_hadr = leptr >> 16;
@@ -399,7 +399,7 @@  static void lance_init_ring_pio(struct net_device *dev)
 	sbus_writeb(dev->dev_addr[4], &ib->phys_addr[5]);
 
 	/* Setup the Tx ring entries */
-	for (i = 0; i <= TX_RING_SIZE; i++) {
+	for (i = 0; i < TX_RING_SIZE; i++) {
 		leptr = libbuff_offset(tx_buf, i);
 		sbus_writew(leptr,	&ib->btx_ring [i].tmd0);
 		sbus_writeb(leptr >> 16,&ib->btx_ring [i].tmd1_hadr);