From patchwork Sat Sep 14 21:54:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 274973 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AB9862C014C for ; Sun, 15 Sep 2013 08:08:34 +1000 (EST) Received: from localhost ([::1]:54767 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKy12-0003as-Jw for incoming@patchwork.ozlabs.org; Sat, 14 Sep 2013 18:08:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKxoV-0001m0-RU for qemu-devel@nongnu.org; Sat, 14 Sep 2013 17:55:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKxoP-00048w-QP for qemu-devel@nongnu.org; Sat, 14 Sep 2013 17:55:35 -0400 Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]:51583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKxoP-00048q-JL for qemu-devel@nongnu.org; Sat, 14 Sep 2013 17:55:29 -0400 Received: by mail-pa0-f50.google.com with SMTP id fb10so3891545pad.37 for ; Sat, 14 Sep 2013 14:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=yBu0WRxsqEzX09CFfbpheadWCqdJUZDGpz9UorEm4Pw=; b=PaWfVwuqfyzUhK5KiPbUoVqxLwiW9ow85LihZ5UCXT6+H4Fm2+vwzP5mdLvqiEZgiS RuXUVL6ap9tCVYxr0no1N4NZE+Xf0sslspXzIaygg9wmwVXg4Wp10jDzDweabOAC2f+0 xS0geCfyEsv+jFUdke0z6RWkuPoQNkJOA40m2NrVR5Fok83v2gd4jvEYeSCEO2g+i3cn XSBXDQWl9qu/jJpQ2hfUhLm36SDxQaApynsA3s+41o8MEzVmBWV9TeSeKygcj276DSE1 CAe6q8qGa78r8l59FJavFXQzFVz0hA9kMokIugno/oOz44ucUyG1vUoqDSPEx9SUNOMa SbbA== X-Received: by 10.66.155.36 with SMTP id vt4mr22492754pab.93.1379195728697; Sat, 14 Sep 2013 14:55:28 -0700 (PDT) Received: from pebble.twiddle.net (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id gg10sm20458962pbc.46.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 14 Sep 2013 14:55:28 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sat, 14 Sep 2013 14:54:40 -0700 Message-Id: <1379195690-6509-24-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1379195690-6509-1-git-send-email-rth@twiddle.net> References: <1379195690-6509-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::232 Cc: peter.maydell@linaro.org, claudio.fontana@gmail.com Subject: [Qemu-devel] [PATCH v4 23/33] tcg-aarch64: Use ORRI in tcg_out_movi X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The subset of logical immediates that we support is quite quick to test, and such constants are quite common to want to load. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index cecda05..9effee7 100644 --- a/tcg/aarch64/tcg-target.c +++ b/tcg/aarch64/tcg-target.c @@ -573,6 +573,15 @@ static void tcg_out_movi(TCGContext *s, TCGType type, TCGReg rd, type = TCG_TYPE_I32; } + /* Check for bitfield immediates. For the benefit of 32-bit quantities, + use the sign-extended value. That lets us match rotated values such + as 0xff0000ff with the same 64-bit logic matching 0xffffffffff0000ff. + The truncation happens inside tcg_fmt_Rdn_limm. */ + if (is_limm(svalue)) { + tcg_fmt_Rdn_limm(s, INSN_ORRI, type, rd, TCG_REG_XZR, svalue); + return; + } + /* Would it take fewer insns to begin with MOVN? For the value and its inverse, count the number of 16-bit lanes that are 0. For the benefit of 32-bit quantities, compare the zero-extended normal value vs the