| Message ID | 1379094304-22041-3-git-send-email-Larry.Finger@lwfinger.net |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 09/13/2013 09:44 PM, Larry Finger wrote: > Smatch lists the following: > CHECK drivers/net/wireless/rtlwifi/rtl8192de/hw.c > drivers/net/wireless/rtlwifi/rtl8192de/hw.c:1200 rtl92de_set_qos() info: ignoring unreachable code. > drivers/net/wireless/rtlwifi/rtl8192de/hw.c:1200 rtl92de_set_qos() info: ignoring unreachable code. > Dead code is removed. It is instead commented out, including non-dead code it seems... > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > --- > drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c > index 7dd8f6d..c9b0894 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c > @@ -1194,6 +1194,7 @@ void rtl92d_linked_set_reg(struct ieee80211_hw *hw) > * mac80211 will send pkt when scan */ > void rtl92de_set_qos(struct ieee80211_hw *hw, int aci) > { > +/* > struct rtl_priv *rtlpriv = rtl_priv(hw); > rtl92d_dm_init_edca_turbo(hw); > return; Shouldn't the comment start here (and *return* removed)? It's also better to remove the dead code than just to comment it out. > @@ -1213,6 +1214,7 @@ void rtl92de_set_qos(struct ieee80211_hw *hw, int aci) > RT_ASSERT(false, "invalid aci: %d !\n", aci); > break; > } > + */ > } WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/14/2013 02:59 PM, Sergei Shtylyov wrote: > Hello. > > On 09/13/2013 09:44 PM, Larry Finger wrote: > >> Smatch lists the following: >> CHECK drivers/net/wireless/rtlwifi/rtl8192de/hw.c >> drivers/net/wireless/rtlwifi/rtl8192de/hw.c:1200 rtl92de_set_qos() info: >> ignoring unreachable code. >> drivers/net/wireless/rtlwifi/rtl8192de/hw.c:1200 rtl92de_set_qos() info: >> ignoring unreachable code. > >> Dead code is removed. > > It is instead commented out, including non-dead code it seems... > >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> >> --- >> drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c >> b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c >> index 7dd8f6d..c9b0894 100644 >> --- a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c >> +++ b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c >> @@ -1194,6 +1194,7 @@ void rtl92d_linked_set_reg(struct ieee80211_hw *hw) >> * mac80211 will send pkt when scan */ >> void rtl92de_set_qos(struct ieee80211_hw *hw, int aci) >> { >> +/* >> struct rtl_priv *rtlpriv = rtl_priv(hw); >> rtl92d_dm_init_edca_turbo(hw); >> return; > > Shouldn't the comment start here (and *return* removed)? It's also > better to remove the dead code than just to comment it out. That would leave some unused variables. >> @@ -1213,6 +1214,7 @@ void rtl92de_set_qos(struct ieee80211_hw *hw, int aci) >> RT_ASSERT(false, "invalid aci: %d !\n", aci); >> break; >> } >> + */ >> } I'm not sure what that unreachable code might do, thus I saved it as a comment for possible future use. I need to do further evaluation on this fragment, and probably consult with the Realtek engineers. Larry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c index 7dd8f6d..c9b0894 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c @@ -1194,6 +1194,7 @@ void rtl92d_linked_set_reg(struct ieee80211_hw *hw) * mac80211 will send pkt when scan */ void rtl92de_set_qos(struct ieee80211_hw *hw, int aci) { +/* struct rtl_priv *rtlpriv = rtl_priv(hw); rtl92d_dm_init_edca_turbo(hw); return; @@ -1213,6 +1214,7 @@ void rtl92de_set_qos(struct ieee80211_hw *hw, int aci) RT_ASSERT(false, "invalid aci: %d !\n", aci); break; } + */ } void rtl92de_enable_interrupt(struct ieee80211_hw *hw)
Smatch lists the following: CHECK drivers/net/wireless/rtlwifi/rtl8192de/hw.c drivers/net/wireless/rtlwifi/rtl8192de/hw.c:1200 rtl92de_set_qos() info: ignoring unreachable code. drivers/net/wireless/rtlwifi/rtl8192de/hw.c:1200 rtl92de_set_qos() info: ignoring unreachable code. Dead code is removed. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> --- drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 2 ++ 1 file changed, 2 insertions(+)