Patchwork [RFC] Offloading Support in libgomp

login
register
mail settings
Submitter Jakub Jelinek
Date Sept. 13, 2013, 3:35 p.m.
Message ID <20130913153527.GH1817@tucnak.redhat.com>
Download mbox | patch
Permalink /patch/274800/
State New
Headers show

Comments

Jakub Jelinek - Sept. 13, 2013, 3:35 p.m.
On Fri, Sep 13, 2013 at 03:15:56PM +0200, Jakub Jelinek wrote:
> On Fri, Sep 13, 2013 at 05:11:09PM +0400, Michael V. Zolotukhin wrote:
> > > FYI, I'm attaching a WIP patch with the splay tree stuff.
> > Thanks, I'll take a look.  By the way, isn't it better to move splay-tree
> > implementation to a separate file?
> 
> As it is just a few routines, heavily modified from include/splay-tree.h
> (e.g. the data structures contain all the target.c specific stuff), and will be
> used just in target.c, I think it is fine to keep it in target.c.

Anyway, here is an updated patch that moves the splay stuff into
splay-tree.h and cleans up a bunch of other things.

Will commit once the http://gcc.gnu.org/ml/gcc-patches/2013-09/msg01044.html
issue is resolved.

2013-09-13  Jakub Jelinek  <jakub@redhat.com>

	* ipa-prop.c (ipa_compute_jump_functions_for_edge): Return early
	for internal calls.



	Jakub
Marek Polacek - Sept. 13, 2013, 3:41 p.m.
On Fri, Sep 13, 2013 at 05:35:27PM +0200, Jakub Jelinek wrote:
> On Fri, Sep 13, 2013 at 03:15:56PM +0200, Jakub Jelinek wrote:
> > On Fri, Sep 13, 2013 at 05:11:09PM +0400, Michael V. Zolotukhin wrote:
> > > > FYI, I'm attaching a WIP patch with the splay tree stuff.
> > > Thanks, I'll take a look.  By the way, isn't it better to move splay-tree
> > > implementation to a separate file?
> > 
> > As it is just a few routines, heavily modified from include/splay-tree.h
> > (e.g. the data structures contain all the target.c specific stuff), and will be
> > used just in target.c, I think it is fine to keep it in target.c.
> 
> Anyway, here is an updated patch that moves the splay stuff into
> splay-tree.h and cleans up a bunch of other things.
> 
> Will commit once the http://gcc.gnu.org/ml/gcc-patches/2013-09/msg01044.html
> issue is resolved.
> 
> 2013-09-13  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* ipa-prop.c (ipa_compute_jump_functions_for_edge): Return early
> 	for internal calls.

Seems like a wrong patch is attached.

	Marek

Patch

--- gcc/ipa-prop.c.jj	2013-09-13 16:48:54.000000000 +0200
+++ gcc/ipa-prop.c	2013-09-13 17:28:28.086058903 +0200
@@ -1551,6 +1551,8 @@  ipa_compute_jump_functions_for_edge (str
     return;
   vec_safe_grow_cleared (args->jump_functions, arg_num);
 
+  if (gimple_call_internal_p (call))
+    return;
   if (ipa_func_spec_opts_forbid_analysis_p (cs->caller))
     return;