Patchwork pci: remove explicit check to 64K ioport size

login
register
mail settings
Submitter Hervé Poussineau
Date Sept. 13, 2013, 11:58 a.m.
Message ID <1379073525-20995-1-git-send-email-hpoussin@reactos.org>
Download mbox | patch
Permalink /patch/274763/
State New
Headers show

Comments

Hervé Poussineau - Sept. 13, 2013, 11:58 a.m.
This check is useless, as bigger addresses will be ignored when
added to 'io' MemoryRegion, which has a size of 64K.

However, some architectures don't use the 'io' MemoryRegion, like
the alpha and versatile platforms. They create a PCI I/O region
bigger than 64K, so let them handle PCI I/O BARs in the higher range.

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/pci/pci.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Richard Henderson - Sept. 14, 2013, 6:40 p.m.
On 09/13/2013 04:58 AM, Hervé Poussineau wrote:
> This check is useless, as bigger addresses will be ignored when
> added to 'io' MemoryRegion, which has a size of 64K.
> 
> However, some architectures don't use the 'io' MemoryRegion, like
> the alpha and versatile platforms. They create a PCI I/O region
> bigger than 64K, so let them handle PCI I/O BARs in the higher range.
> 
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>  hw/pci/pci.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~

Patch

diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index d00682e..a8e2b29 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1028,8 +1028,7 @@  static pcibus_t pci_bar_address(PCIDevice *d,
         }
         new_addr = pci_get_long(d->config + bar) & ~(size - 1);
         last_addr = new_addr + size - 1;
-        /* NOTE: we have only 64K ioports on PC */
-        if (last_addr <= new_addr || new_addr == 0 || last_addr > UINT16_MAX) {
+        if (last_addr <= new_addr || new_addr == 0) {
             return PCI_BAR_UNMAPPED;
         }
         return new_addr;