From patchwork Fri Sep 13 10:25:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Lieven X-Patchwork-Id: 274720 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C8EB12C017A for ; Fri, 13 Sep 2013 20:34:54 +1000 (EST) Received: from localhost ([::1]:45919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKQiC-0008Pz-NC for incoming@patchwork.ozlabs.org; Fri, 13 Sep 2013 06:34:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKQb9-0007Lb-FF for qemu-devel@nongnu.org; Fri, 13 Sep 2013 06:27:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKQb3-0003mH-OF for qemu-devel@nongnu.org; Fri, 13 Sep 2013 06:27:35 -0400 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:54472 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKQb3-0003lX-De for qemu-devel@nongnu.org; Fri, 13 Sep 2013 06:27:29 -0400 Received: (qmail 3118 invoked by uid 89); 13 Sep 2013 10:27:26 -0000 Received: from [82.141.1.145] by client-16-kamp (envelope-from , uid 89) with qmail-scanner-2010/03/19-MF (clamdscan: 0.97.8/17847. hbedv: 8.2.12.118/7.11.102.86. spamassassin: 3.3.1. Clear:RC:1(82.141.1.145):SA:0(-1.2/5.0):. Processed in 1.085934 secs); 13 Sep 2013 10:27:26 -0000 Received: from ns.kamp-intra.net (HELO dns.kamp-intra.net) ([82.141.1.145]) by mx01.kamp.de with SMTP; 13 Sep 2013 10:27:25 -0000 X-GL_Whitelist: yes Received: from lieven-pc.kamp-intra.net (lieven-pc.kamp-intra.net [172.21.12.60]) by dns.kamp-intra.net (Postfix) with ESMTP id 61DFF206B4; Fri, 13 Sep 2013 12:25:15 +0200 (CEST) Received: by lieven-pc.kamp-intra.net (Postfix, from userid 1000) id 65C9D6128B; Fri, 13 Sep 2013 12:25:17 +0200 (CEST) From: Peter Lieven To: qemu-devel@nongnu.org Date: Fri, 13 Sep 2013 12:25:09 +0200 Message-Id: <1379067909-22984-13-git-send-email-pl@kamp.de> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1379067909-22984-1-git-send-email-pl@kamp.de> References: <1379067909-22984-1-git-send-email-pl@kamp.de> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a02:248:0:51::16 Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, Peter Lieven , stefanha@redhat.com, anthony@codemonkey.ws, pbonzini@redhat.com Subject: [Qemu-devel] [PATCH 12/12] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org this patch does 2 things: a) only do additional call outs if BDRV_BLOCK_ZERO is not already set. b) use bdi.discard_zeroes to return the zero state of an unallocated block. the callout to bdrv_has_zero_init() is only valid right after bdrv_create. Signed-off-by: Peter Lieven --- block.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 282943b..6698c10 100644 --- a/block.c +++ b/block.c @@ -3153,8 +3153,10 @@ static int64_t coroutine_fn bdrv_co_get_block_status(BlockDriverState *bs, return ret; } - if (!(ret & BDRV_BLOCK_DATA)) { - if (bdrv_has_zero_init(bs)) { + if (!(ret & BDRV_BLOCK_DATA) && !(ret & BDRV_BLOCK_ZERO)) { + BlockDriverInfo bdi; + if (bdrv_get_info(bs, &bdi) == 0 && + bdi.discard_zeroes) { ret |= BDRV_BLOCK_ZERO; } else if (bs->backing_hd) { BlockDriverState *bs2 = bs->backing_hd;