From patchwork Fri Sep 13 10:13:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Murray X-Patchwork-Id: 274708 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 44E4E2C0139 for ; Fri, 13 Sep 2013 20:19:26 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C3B064A0C9; Fri, 13 Sep 2013 12:19:19 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NdcaUr91Ugje; Fri, 13 Sep 2013 12:19:19 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B29F84A0B5; Fri, 13 Sep 2013 12:19:14 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C80394A0B5 for ; Fri, 13 Sep 2013 12:19:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mGQBSrKy8p3z for ; Fri, 13 Sep 2013 12:19:05 +0200 (CEST) X-Greylist: delayed 302 seconds by postgrey-1.27 at theia; Fri, 13 Sep 2013 12:18:57 CEST X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 BL_NJABL=ERR(-1.5) (only DNSBL check requested) Received: from mail-we0-f180.google.com (mail-we0-f180.google.com [74.125.82.180]) by theia.denx.de (Postfix) with ESMTPS id 12EAE4A0B3 for ; Fri, 13 Sep 2013 12:18:57 +0200 (CEST) Received: by mail-we0-f180.google.com with SMTP id u57so937875wes.11 for ; Fri, 13 Sep 2013 03:18:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=iITiIn8y1r7qbHD8Mh+HtNi39RodfHjLMMt3tyjNKmM=; b=OE58CEHpYEibzpLzZas7h1sBy1E4c6GKmhlfkhOtFlOdSnOIWR9HFjO79JsAkPrPg6 1cnYHR2Q1fuLZPFS0TDOIb4JtU+8NqonHCUY3bkHFQhM9i9ap0JhN91GddkKqeUML2hE 3X0OELmvnfbHYwV6q43pqwAx9s+kzrrQVwLtJgDKyhp3Z0OyI/k4g6XUDkdMuSMQ5/eK 06wWvmqBOEEdXg6Blnu+/l1CNeKwwvaENMgkVjs3jHoAWLid0pLA3/bnRUk/xgNWW2nH qzJhDBVL8lQUgoKx393ACcqSc3QP+WoaoUes4oY1gCArFaOqyqIK1Wcr2Jc/PMFOpWv1 dMMw== X-Gm-Message-State: ALoCoQnlWmFFylV4JqREN2YCW0uzkusp49v4bvwJs9rEAdvQ249SIV7fFglpyImgvbFh3UCW/bKN X-Received: by 10.180.82.164 with SMTP id j4mr1811181wiy.65.1379067235056; Fri, 13 Sep 2013 03:13:55 -0700 (PDT) Received: from localhost.localdomain (host-89-241-119-12.as13285.net. [89.241.119.12]) by mx.google.com with ESMTPSA id fz8sm2388393wic.0.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Sep 2013 03:13:54 -0700 (PDT) From: Andrew Murray To: u-boot@lists.denx.de Date: Fri, 13 Sep 2013 11:13:09 +0100 Message-Id: <1379067189-2082-1-git-send-email-amurray@embedded-bits.co.uk> X-Mailer: git-send-email 1.7.9.5 Cc: Marek Vasut , Tom Rini Subject: [U-Boot] [PATCH RFC] usb: Prevent using reserved registers on DM36x usb X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de The musb driver defines and uses MUSB_CSR0_H_DIS_PING, however this bit is reserved on the DM36x. Thus this patch ensures that the reserved bit is not accesssed. It has been observed that some USB devices will fail to enumerate with errors such as 'error in inquiry' without this patch. See http://www.ti.com/litv/pdf/sprufh9a for details. Cc: Marek Vasut Cc: Tom Rini Signed-off-by: Andrew Murray --- drivers/usb/musb/musb_core.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h index ec8a038..c9a9d66 100644 --- a/drivers/usb/musb/musb_core.h +++ b/drivers/usb/musb/musb_core.h @@ -216,7 +216,11 @@ struct musb_regs { #define MUSB_CSR0_P_SENTSTALL 0x0004 /* CSR0 in Host mode */ +#if defined(CONFIG_SOC_DM365) +#define MUSB_CSR0_H_DIS_PING 0x0000 +#else #define MUSB_CSR0_H_DIS_PING 0x0800 +#endif #define MUSB_CSR0_H_WR_DATATOGGLE 0x0400 /* Set to allow setting: */ #define MUSB_CSR0_H_DATATOGGLE 0x0200 /* Data toggle control */ #define MUSB_CSR0_H_NAKTIMEOUT 0x0080