Patchwork [U-Boot,2/4] powerpc/eeprom: update MAX_NUM_PORTS to adapt non-256-bytes EEPROM

login
register
mail settings
Submitter Shengzhou Liu
Date Sept. 13, 2013, 6:46 a.m.
Message ID <1379054763-7406-2-git-send-email-Shengzhou.Liu@freescale.com>
Download mbox | patch
Permalink /patch/274660/
State Accepted
Delegated to: York Sun
Headers show

Comments

Shengzhou Liu - Sept. 13, 2013, 6:46 a.m.
Some boards use System EEPROM with 128-bytes instead of 256-bytes.
Since we regard 256-bytes EEPROM as standard EEPROM with default
value for MAX_NUM_PORTS. For those non-256-bytes EEPROM, we can
redefine MAX_NUM_PORTS in board-specific file to override the
default MAX_NUM_PORTS.

This patch doesn't impact on previous existing boards.

Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
---
Verified with 128B and 256B EEPROM, CRC works.

 board/freescale/common/sys_eeprom.c | 4 ++++
 1 file changed, 4 insertions(+)
York Sun - Sept. 13, 2013, 3:13 p.m.
On 09/12/2013 11:46 PM, Shengzhou Liu wrote:
> Some boards use System EEPROM with 128-bytes instead of 256-bytes.
> Since we regard 256-bytes EEPROM as standard EEPROM with default
> value for MAX_NUM_PORTS. For those non-256-bytes EEPROM, we can
> redefine MAX_NUM_PORTS in board-specific file to override the
> default MAX_NUM_PORTS.
> 
> This patch doesn't impact on previous existing boards.
> 
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> ---
> Verified with 128B and 256B EEPROM, CRC works.
> 
>

I would appreciate it if you update the version number and put a change
log under the --- line, even there is no change. With a clear version
number and change log, reviewers will be able to identify this is a
resend and not spending much time on it.

You are also encouraged to mark previous patch as "superseded".

York
Liu Shengzhou-B36685 - Sept. 16, 2013, 9:55 a.m.
> -----Original Message-----
> From: sun york-R58495
> Sent: Friday, September 13, 2013 11:13 PM
> To: Liu Shengzhou-B36685
> Cc: u-boot@lists.denx.de
> Subject: Re: [PATCH 2/4] powerpc/eeprom: update MAX_NUM_PORTS to adapt non-256-
> bytes EEPROM
> 
> I would appreciate it if you update the version number and put a change log
> under the --- line, even there is no change. With a clear version number and
> change log, reviewers will be able to identify this is a resend and not spending
> much time on it.
> 
> You are also encouraged to mark previous patch as "superseded".
> 
> York
>
Sorry for missing the updated version number, will keep it later.
Previous patch has been marked as "superseded".
Thanks,
Shengzhou

Patch

diff --git a/board/freescale/common/sys_eeprom.c b/board/freescale/common/sys_eeprom.c
index d789364..9c18dd8 100644
--- a/board/freescale/common/sys_eeprom.c
+++ b/board/freescale/common/sys_eeprom.c
@@ -18,7 +18,11 @@ 
 #endif
 
 #ifdef CONFIG_SYS_I2C_EEPROM_NXID
+/* some boards with non-256-bytes EEPROM have special define */
+/* for MAX_NUM_PORTS in board-specific file */
+#ifndef MAX_NUM_PORTS
 #define MAX_NUM_PORTS	23
+#endif
 #define NXID_VERSION	1
 #endif