Patchwork [U-Boot,1/2] mx6sabresd: Return error if cpu_eth_init() fails

login
register
mail settings
Submitter Fabio Estevam
Date Sept. 13, 2013, 1:03 a.m.
Message ID <1379034203-4753-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/274626/
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Sept. 13, 2013, 1:03 a.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

Currently board_eth_init() always return 0, but we should propagate the error 
when cpu_eth_init() fails.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx6sabresd/mx6sabresd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Stefano Babic - Sept. 20, 2013, 4:05 p.m.
On 13/09/2013 03:03, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Currently board_eth_init() always return 0, but we should propagate the error 
> when cpu_eth_init() fails.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx, thanks!

Best regards,
Stefano Babic

Patch

diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index c832bd9..425f734 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -421,7 +421,7 @@  int board_eth_init(bd_t *bis)
 	if (ret)
 		printf("FEC MXC: %s:failed\n", __func__);
 
-	return 0;
+	return ret;
 }
 
 int board_early_init_f(void)