| Message ID | 1379009346-18130-1-git-send-email-sw@weilnetz.de |
|---|---|
| State | Accepted |
| Headers | show |
12.09.2013 22:09, Stefan Weil wrote: > The page dump writes a table with 3 abi_ulong values in each row. > These values take 8 or 16 characters (depending on sizeof abi_ulong). > > Fix the table headings to be aligned with the table columns. Thanks, applied to the trivial-patches queue. /mjt
diff --git a/translate-all.c b/translate-all.c index 2c923c6..3b97c66 100644 --- a/translate-all.c +++ b/translate-all.c @@ -1679,8 +1679,9 @@ static int dump_region(void *priv, abi_ulong start, /* dump memory mappings */ void page_dump(FILE *f) { - (void) fprintf(f, "%-8s %-8s %-8s %s\n", - "start", "end", "size", "prot"); + const size_t length = sizeof(abi_ulong) * 2; + (void) fprintf(f, "%-*s %-*s %-*s %s\n", + length, "start", length, "end", length, "size", "prot"); walk_memory_regions(f, dump_region); }
The page dump writes a table with 3 abi_ulong values in each row. These values take 8 or 16 characters (depending on sizeof abi_ulong). Fix the table headings to be aligned with the table columns. old: start end size prot 0000000120000000-000000012021e000 000000000021e000 rwx 0000004000000000-0000004000002000 0000000000002000 --- 0000004000002000-0000004000802000 0000000000800000 rw- new: start end size prot 0000000120000000-000000012021e000 000000000021e000 rwx 0000004000000000-0000004000002000 0000000000002000 --- 0000004000002000-0000004000802000 0000000000800000 rw- Signed-off-by: Stefan Weil <sw@weilnetz.de> --- translate-all.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)