Patchwork tune2fs: update i_size in ext2fs_file_write()

login
register
mail settings
Submitter Niu Yawei
Date Sept. 12, 2013, 2:21 p.m.
Message ID <5231CDFE.8050206@gmail.com>
Download mbox | patch
Permalink /patch/274561/
State Superseded
Headers show

Comments

Niu Yawei - Sept. 12, 2013, 2:21 p.m.
ext2fs_file_write() needs to update i_size on successful write,
otherwise, ext2fs_file_read() in same open/close cycle will not
be able to read the just written data.

Which result in the the problem of quotacheck triggered on
'tune2fs -O quota' failed to write back multiple users/groups
accounting information.

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
---
 lib/ext2fs/fileio.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

 fail:

Patch

diff --git a/lib/ext2fs/fileio.c b/lib/ext2fs/fileio.c
index 1f7002c..b1b5540 100644
--- a/lib/ext2fs/fileio.c
+++ b/lib/ext2fs/fileio.c
@@ -304,6 +304,13 @@  errcode_t ext2fs_file_write(ext2_file_t file, const
void *buf,
 		ptr += c;
 		count += c;
 		nbytes -= c;
+
+		/* Update inode size */
+		if (EXT2_I_SIZE(&file->inode) < file->pos) {
+			retval = ext2fs_file_set_size2(file, file->pos);
+			if (retval)
+				goto fail;
+		}
 	}