Patchwork [libvtv] Remove Android from supported targets

login
register
mail settings
Submitter Alexander Ivchenko
Date Sept. 12, 2013, 10:56 a.m.
Message ID <CACysShhpXoaqoNGLr2r6tJGUfFRJ73E_F_o1cwzhOL_B=5vzDw@mail.gmail.com>
Download mbox | patch
Permalink /patch/274507/
State New
Headers show

Comments

Alexander Ivchenko - Sept. 12, 2013, 10:56 a.m.
Hi,

We currently have build problem in Android ndk for trunk:

toolchain/gcc/gcc-4.9/libvtv/vtv_rts.cc:124:22: fatal error:
execinfo.h: No such file or directory
 #include <execinfo.h>
                      ^
compilation terminated.
toolchain/gcc/gcc-4.9/libvtv/vtv_utils.cc:36:22: fatal error:
execinfo.h: No such file or directory
 #include <execinfo.h>
                      ^
compilation terminated.
make[4]: *** [vtv_rts.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: *** [vtv_utils.lo] Error 1


There is no execinfo.h in Bionic.

Is following patch OK?



thanks,
Alexander
Caroline Tice - Sept. 12, 2013, 3:19 p.m.
Yes, that patch is ok.

-- Caroline Tice
cmtice@google.com

On Thu, Sep 12, 2013 at 3:56 AM, Alexander Ivchenko <aivchenk@gmail.com> wrote:
> Hi,
>
> We currently have build problem in Android ndk for trunk:
>
> toolchain/gcc/gcc-4.9/libvtv/vtv_rts.cc:124:22: fatal error:
> execinfo.h: No such file or directory
>  #include <execinfo.h>
>                       ^
> compilation terminated.
> toolchain/gcc/gcc-4.9/libvtv/vtv_utils.cc:36:22: fatal error:
> execinfo.h: No such file or directory
>  #include <execinfo.h>
>                       ^
> compilation terminated.
> make[4]: *** [vtv_rts.lo] Error 1
> make[4]: *** Waiting for unfinished jobs....
> make[4]: *** [vtv_utils.lo] Error 1
>
>
> There is no execinfo.h in Bionic.
>
> Is following patch OK?
>
> diff --git a/libvtv/ChangeLog b/libvtv/ChangeLog
> index 3c344f9..f0a7471 100644
> --- a/libvtv/ChangeLog
> +++ b/libvtv/ChangeLog
> @@ -1,3 +1,7 @@
> +2013-09-12  Alexander Ivchenko  <alexander.ivchenko@intel.com>
> +
> +       * configure.tgt: Remove *-*-*android* from supported targets.
> +
>  2013-09-09  H.J. Lu  <hongjiu.lu@intel.com>
>
>         PR other/58374
> diff --git a/libvtv/configure.tgt b/libvtv/configure.tgt
> index 801d2f0..046b415 100644
> --- a/libvtv/configure.tgt
> +++ b/libvtv/configure.tgt
> @@ -21,6 +21,8 @@
>  # Filter out unsupported systems.
>  VTV_SUPPORTED=no
>  case "${target}" in
> +  *-*-*android*)
> +       ;;
>    x86_64-*-linux* | i?86-*-linux*)
>         VTV_SUPPORTED=yes
>         ;;
>
>
> thanks,
> Alexander
Kirill Yukhin - Sept. 13, 2013, 11:22 a.m.
Hello,
On 12 Sep 08:19, Caroline Tice wrote:
> Yes, that patch is ok.
> 
> -- Caroline Tice
> cmtice@google.com
> 
> On Thu, Sep 12, 2013 at 3:56 AM, Alexander Ivchenko <aivchenk@gmail.com> wrote:
> >
> > Is following patch OK?

Checked into main trunk: http://gcc.gnu.org/ml/gcc-cvs/2013-09/msg00425.html

--
Thanks, K

Patch

diff --git a/libvtv/ChangeLog b/libvtv/ChangeLog
index 3c344f9..f0a7471 100644
--- a/libvtv/ChangeLog
+++ b/libvtv/ChangeLog
@@ -1,3 +1,7 @@ 
+2013-09-12  Alexander Ivchenko  <alexander.ivchenko@intel.com>
+
+       * configure.tgt: Remove *-*-*android* from supported targets.
+
 2013-09-09  H.J. Lu  <hongjiu.lu@intel.com>

        PR other/58374
diff --git a/libvtv/configure.tgt b/libvtv/configure.tgt
index 801d2f0..046b415 100644
--- a/libvtv/configure.tgt
+++ b/libvtv/configure.tgt
@@ -21,6 +21,8 @@ 
 # Filter out unsupported systems.
 VTV_SUPPORTED=no
 case "${target}" in
+  *-*-*android*)
+       ;;
   x86_64-*-linux* | i?86-*-linux*)
        VTV_SUPPORTED=yes
        ;;